From f0eddb102890fe2ff8f13aa4df4e460417705401 Mon Sep 17 00:00:00 2001
From: Sarah Diedrich <sarah.diedrich@greenbone.net>
Date: Tue, 23 Apr 2019 14:48:30 +0200
Subject: [PATCH 1/2] Remove sort by credential type from Target view

---
 gsa/src/web/pages/targets/table.js | 48 +-----------------------------
 1 file changed, 1 insertion(+), 47 deletions(-)

diff --git a/gsa/src/web/pages/targets/table.js b/gsa/src/web/pages/targets/table.js
index a7ac7fd382..e374761f14 100644
--- a/gsa/src/web/pages/targets/table.js
+++ b/gsa/src/web/pages/targets/table.js
@@ -27,12 +27,6 @@ import {withEntitiesHeader} from 'web/entities/header';
 import {createEntitiesTable} from 'web/entities/table';
 import withRowDetails from 'web/entities/withRowDetails';
 
-import Select from 'web/components/form/select';
-
-import Divider from 'web/components/layout/divider';
-
-import Sort from 'web/components/sortby/sortby';
-
 import TableHead from 'web/components/table/head';
 import TableHeader from 'web/components/table/header';
 import TableRow from 'web/components/table/row';
@@ -49,16 +43,6 @@ const Header = ({
   currentSortDir,
   onSortChange,
 }) => {
-  let selectSort = 'ssh_credential';
-  const sortBy = filter ? filter.getSortBy() : undefined;
-
-  if (
-    sortBy === 'smb_credential' ||
-    sortBy === 'esxi_credential' ||
-    sortBy === 'snmp_credential'
-  ) {
-    selectSort = sortBy;
-  }
   return (
     <TableHeader>
       <TableRow>
@@ -98,37 +82,7 @@ const Header = ({
         >
           {_('Port List')}
         </TableHead>
-        <TableHead width="22%">
-          <Divider>
-            <Sort by={sort ? selectSort : false} onClick={onSortChange}>
-              {_('Credentials')}
-            </Sort>
-            {sort !== false && (
-              <Select
-                items={[
-                  {
-                    value: 'ssh_credential',
-                    label: _('SSH'),
-                  },
-                  {
-                    value: 'smb_credential',
-                    label: _('SMB'),
-                  },
-                  {
-                    value: 'esxi_credential',
-                    label: _('ESXi'),
-                  },
-                  {
-                    value: 'snmp_credential',
-                    label: _('SNMP'),
-                  },
-                ]}
-                value={selectSort}
-                onChange={onSortChange}
-              />
-            )}
-          </Divider>
-        </TableHead>
+        <TableHead width="15%">{_('Credentials')}</TableHead>
         {actionsColumn}
       </TableRow>
     </TableHeader>

From 59ca0b37efc00ced06d9c66dd6fabc34d41d508b Mon Sep 17 00:00:00 2001
From: Sarah Diedrich <sarah.diedrich@greenbone.net>
Date: Tue, 23 Apr 2019 14:52:09 +0200
Subject: [PATCH 2/2] update changelog

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 600cd88209..6edf6491e4 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -41,6 +41,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Fix release build [#1259](https://github.com/greenbone/gsa/pull/1259), [#1265](https://github.com/greenbone/gsa/pull/1265)
 
 ### Removed
+- Remove sort by credential from Target view [1300](https://github.com/greenbone/gsa/pull/1300)
 - Remove fifth from schedule [#1279](https://github.com/greenbone/gsa/pull/1279)
 - Removed obsolete CLI arguments [#1265](https://github.com/greenbone/gsa/pull/1265)
   - --login-label