From b4216c3458bdc44996a645e41ec12e5f1183d8ec Mon Sep 17 00:00:00 2001
From: Ahmed Abdelsalam <ahmed.abdelsalam@greenbone.net>
Date: Tue, 24 Oct 2023 09:38:43 +0200
Subject: [PATCH] Change: Change opening direction of dropdown menus

Dropdown menus for select and multi-select components can now open upwards
if space below is not enough to prevent extending beyond the viewport.
---
 .../__snapshots__/selectelement.js.snap       | 70 +++++++++++++++++++
 .../form/__tests__/selectelement.js           | 33 ++++++++-
 src/web/components/form/multiselect.js        | 13 +++-
 src/web/components/form/select.js             | 13 +++-
 src/web/components/form/selectelements.js     | 13 +++-
 5 files changed, 136 insertions(+), 6 deletions(-)

diff --git a/src/web/components/form/__tests__/__snapshots__/selectelement.js.snap b/src/web/components/form/__tests__/__snapshots__/selectelement.js.snap
index 3432c81098..0a3b4ad880 100644
--- a/src/web/components/form/__tests__/__snapshots__/selectelement.js.snap
+++ b/src/web/components/form/__tests__/__snapshots__/selectelement.js.snap
@@ -216,6 +216,76 @@ exports[`Menu tests should render 1`] = `
 />
 `;
 
+exports[`Menu tests should render with open direction downwards 1`] = `
+.c0 {
+  outline: 0;
+  border-radius: 0 0 4px 4px;
+  -webkit-transition: opacity 0.1s ease;
+  transition: opacity 0.1s ease;
+  box-shadow: 0 2px 3px 0 rgba(34, 36, 38, 0.15);
+  border: 1px solid #bfbfbf;
+  background-color: #fff;
+  display: -webkit-box;
+  display: -webkit-flex;
+  display: -ms-flexbox;
+  display: flex;
+  -webkit-flex-direction: column;
+  -ms-flex-direction: column;
+  flex-direction: column;
+  position: absolute;
+  z-index: 600;
+  margin-top: -1px;
+  box-sizing: border-box;
+  top: 120px;
+  left: 50px;
+  white-space: nowrap;
+}
+
+<div
+  class="c0"
+  data-testid="select-menu"
+  right="-10"
+  width="100"
+  x="50"
+  y="120"
+/>
+`;
+
+exports[`Menu tests should render with open direction upwards 1`] = `
+.c0 {
+  outline: 0;
+  border-radius: 0 0 4px 4px;
+  -webkit-transition: opacity 0.1s ease;
+  transition: opacity 0.1s ease;
+  box-shadow: 0 2px 3px 0 rgba(34, 36, 38, 0.15);
+  border: 1px solid #bfbfbf;
+  background-color: #fff;
+  display: -webkit-box;
+  display: -webkit-flex;
+  display: -ms-flexbox;
+  display: flex;
+  -webkit-flex-direction: column;
+  -ms-flex-direction: column;
+  flex-direction: column;
+  position: absolute;
+  z-index: 600;
+  margin-top: -1px;
+  box-sizing: border-box;
+  top: 25px;
+  left: 50px;
+  white-space: nowrap;
+}
+
+<div
+  class="c0"
+  data-testid="select-menu"
+  right="-10"
+  width="100"
+  x="50"
+  y="25"
+/>
+`;
+
 exports[`Menu tests should render with position adjust 1`] = `
 .c0 {
   outline: 0;
diff --git a/src/web/components/form/__tests__/selectelement.js b/src/web/components/form/__tests__/selectelement.js
index ae93751b5b..0b4471dc3e 100644
--- a/src/web/components/form/__tests__/selectelement.js
+++ b/src/web/components/form/__tests__/selectelement.js
@@ -209,6 +209,7 @@ class MenuTestComponent extends React.Component {
 
     this.target = React.createRef();
     this.mockBoundingClientRect = this.props.mockBoundingClientRect;
+    this.notifyRefAssigned = jest.fn();
   }
 
   render() {
@@ -235,7 +236,13 @@ class MenuTestComponent extends React.Component {
           className={this.mockBoundingClientRect ? 'multiselect-scroll' : ''}
           style={{width: '200px', height: '100px'}}
         />
-        {hasTarget && <Menu {...this.props} target={this.target} />}
+        {hasTarget && (
+          <Menu
+            {...this.props}
+            notifyRefAssigned={this.notifyRefAssigned}
+            target={this.target}
+          />
+        )}
       </div>
     );
   }
@@ -246,6 +253,7 @@ MenuTestComponent.propTypes = {
 };
 
 describe('Menu tests', () => {
+  window.innerHeight = 180;
   const renderTest = props => {
     const {rerender, ...other} = render(<MenuTestComponent {...props} />);
     rerender(<MenuTestComponent {...props} />);
@@ -282,12 +290,33 @@ describe('Menu tests', () => {
   });
 
   test('should not render without target', () => {
-    const {queryByTestId} = render(<Menu target={null} />);
+    const notifyRefAssigned = jest.fn();
+    const {queryByTestId} = render(
+      <Menu target={null} notifyRefAssigned={notifyRefAssigned} />,
+    );
 
     const menu = queryByTestId('select-menu');
 
     expect(menu).toBeNull();
   });
+
+  test('should render with open direction upwards', () => {
+    const {getByTestId} = renderTest({
+      mockBoundingClientRect: true,
+      menuHeight: 75,
+    });
+    const menu = getByTestId('select-menu');
+    expect(menu).toMatchSnapshot();
+  });
+
+  test('should render with open direction downwards', () => {
+    const {getByTestId} = renderTest({
+      mockBoundingClientRect: true,
+      menuHeight: 55,
+    });
+    const menu = getByTestId('select-menu');
+    expect(menu).toMatchSnapshot();
+  });
 });
 
 // vim: set ts=2 sw=2 tw=80:
diff --git a/src/web/components/form/multiselect.js b/src/web/components/form/multiselect.js
index ff4c919d31..ed9c076212 100644
--- a/src/web/components/form/multiselect.js
+++ b/src/web/components/form/multiselect.js
@@ -85,15 +85,22 @@ class MultiSelect extends React.Component {
 
     this.state = {
       search: '',
+      isMenuRefAssigned: false,
     };
 
     this.input = React.createRef();
     this.box = React.createRef();
+    this.menu = React.createRef();
 
     this.handleRemoveItem = this.handleRemoveItem.bind(this);
     this.handleSearch = this.handleSearch.bind(this);
     this.handleSelect = this.handleSelect.bind(this);
     this.renderItem = this.renderItem.bind(this);
+    this.notifyRefAssigned = this.notifyRefAssigned.bind(this);
+  }
+
+  notifyRefAssigned() {
+    this.setState({isMenuRefAssigned: true});
   }
 
   notifyChange(value) {
@@ -242,9 +249,13 @@ class MultiSelect extends React.Component {
                 </Box>
                 {isOpen && !disabled && (
                   <Menu
-                    {...getMenuProps({})}
+                    {...getMenuProps({ref: this.menu})}
                     position={menuPosition}
                     target={this.box}
+                    menuHeight={
+                      this.menu.current?.getBoundingClientRect().height
+                    }
+                    notifyRefAssigned={this.notifyRefAssigned}
                   >
                     <Input
                       {...getInputProps({
diff --git a/src/web/components/form/select.js b/src/web/components/form/select.js
index e1277c2f2f..2287ed7cc8 100644
--- a/src/web/components/form/select.js
+++ b/src/web/components/form/select.js
@@ -108,14 +108,21 @@ class Select extends React.Component {
 
     this.state = {
       search: '',
+      isMenuRefAssigned: false,
     };
 
     this.input = React.createRef();
     this.box = React.createRef();
+    this.menu = React.createRef();
 
     this.handleChange = this.handleChange.bind(this);
     this.handleSearch = this.handleSearch.bind(this);
     this.handleSelect = this.handleSelect.bind(this);
+    this.notifyRefAssigned = this.notifyRefAssigned.bind(this);
+  }
+
+  notifyRefAssigned() {
+    this.setState({isMenuRefAssigned: true});
   }
 
   handleChange(value) {
@@ -237,9 +244,13 @@ class Select extends React.Component {
                 </Box>
                 {isOpen && !disabled && (
                   <Menu
-                    {...getMenuProps({})}
+                    {...getMenuProps({ref: this.menu})}
                     position={menuPosition}
                     target={this.box}
+                    menuHeight={
+                      this.menu.current?.getBoundingClientRect().height
+                    }
+                    notifyRefAssigned={this.notifyRefAssigned}
                   >
                     <Input
                       {...getInputProps({
diff --git a/src/web/components/form/selectelements.js b/src/web/components/form/selectelements.js
index 8231e337db..1e70d2e2dd 100644
--- a/src/web/components/form/selectelements.js
+++ b/src/web/components/form/selectelements.js
@@ -184,6 +184,7 @@ class MenuComponent extends React.Component {
     if (this.eventTarget !== window) {
       window.addEventListener('scroll', this.handleScroll, {passive: true});
     }
+    this.props.notifyRefAssigned();
   }
 
   componentWillUnmount() {
@@ -195,7 +196,7 @@ class MenuComponent extends React.Component {
   }
 
   render() {
-    const {target, forwardedRef, ...props} = this.props;
+    const {target, forwardedRef, menuHeight, ...props} = this.props;
 
     if (!hasValue(target) || target.current === null) {
       return null;
@@ -207,6 +208,8 @@ class MenuComponent extends React.Component {
 
     const {height, width, right, left, top} = rect;
 
+    const y = top + getScrollY() + height;
+
     return (
       <Portal>
         <MenuContainer
@@ -216,7 +219,11 @@ class MenuComponent extends React.Component {
           right={document.body.clientWidth - right}
           width={width}
           x={left + getScrollX()}
-          y={top + getScrollY() + height}
+          y={
+            hasValue(menuHeight) && window.innerHeight - y < menuHeight
+              ? top + getScrollY() - menuHeight
+              : y
+          }
         />
       </Portal>
     );
@@ -225,6 +232,8 @@ class MenuComponent extends React.Component {
 
 MenuComponent.propTypes = {
   forwardedRef: PropTypes.ref,
+  menuHeight: PropTypes.number,
+  notifyRefAssigned: PropTypes.func,
   target: PropTypes.ref,
 };