From d2f437cfe47611be3284b85dc201d26a55149301 Mon Sep 17 00:00:00 2001 From: Steffen Waterkamp Date: Tue, 6 Aug 2019 17:32:02 +0200 Subject: [PATCH 1/4] Set DEFAULT_MANUAL_URL to use GOS 5 manual --- gsa/src/gmp/gmpsettings.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gsa/src/gmp/gmpsettings.js b/gsa/src/gmp/gmpsettings.js index ee599d4a73..3980bfa9d9 100644 --- a/gsa/src/gmp/gmpsettings.js +++ b/gsa/src/gmp/gmpsettings.js @@ -19,7 +19,7 @@ import {isDefined} from './utils/identity'; export const DEFAULT_RELOAD_INTERVAL = 15 * 1000; // fifteen seconds -export const DEFAULT_MANUAL_URL = 'http://docs.greenbone.net/GSM-Manual/gos-4/'; +export const DEFAULT_MANUAL_URL = 'http://docs.greenbone.net/GSM-Manual/gos-5/'; export const DEFAULT_PROTOCOLDOC_URL = 'https://docs.greenbone.net/API/GMP/gmp-8.0.html'; export const DEFAULT_LOG_LEVEL = 'warn'; From f1b99a6e78d7e6adbffa7c7bd3d4b5c04222c9bb Mon Sep 17 00:00:00 2001 From: Steffen Waterkamp Date: Tue, 6 Aug 2019 18:56:42 +0200 Subject: [PATCH 2/4] Add new HelpIcon to Dashboards page (start) --- gsa/src/web/pages/start/page.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gsa/src/web/pages/start/page.js b/gsa/src/web/pages/start/page.js index b385453e82..d3fd63506c 100644 --- a/gsa/src/web/pages/start/page.js +++ b/gsa/src/web/pages/start/page.js @@ -53,6 +53,7 @@ import { import DashboardIcon from 'web/components/icon/dashboardicon'; import DeleteIcon from 'web/components/icon/deleteicon'; import EditIcon from 'web/components/icon/editicon'; +import ManualIcon from 'web/components/icon/manualicon'; import NewIcon from 'web/components/icon/newicon'; import IconDivider from 'web/components/layout/icondivider'; @@ -107,6 +108,14 @@ const StyledTab = styled(Tab)` } `; +const ToolBarIcons = () => ( + +); + class StartPage extends React.Component { constructor(...args) { super(...args); @@ -391,6 +400,7 @@ class StartPage extends React.Component { const canAdd = dashboards.length < MAX_DASHBOARDS; return ( +
}> {isLoading ? ( From f4d53d724c512b27268e35ded9779107fdd5d2ab Mon Sep 17 00:00:00 2001 From: Steffen Waterkamp Date: Tue, 6 Aug 2019 18:58:13 +0200 Subject: [PATCH 3/4] Update Links to Manual in HelpIcon ...and add HelpIcon to Tickets --- gsa/src/web/pages/alerts/detailspage.js | 4 ++-- gsa/src/web/pages/alerts/listpage.js | 4 ++-- gsa/src/web/pages/certbund/detailspage.js | 4 ++-- gsa/src/web/pages/certbund/listpage.js | 4 ++-- gsa/src/web/pages/cpes/detailspage.js | 2 +- gsa/src/web/pages/cpes/listpage.js | 6 +----- gsa/src/web/pages/credentials/detailspage.js | 4 ++-- gsa/src/web/pages/credentials/listpage.js | 4 ++-- gsa/src/web/pages/cves/detailspage.js | 2 +- gsa/src/web/pages/cves/listpage.js | 6 +----- gsa/src/web/pages/dfncert/detailspage.js | 4 ++-- gsa/src/web/pages/dfncert/listpage.js | 4 ++-- gsa/src/web/pages/extras/cvsscalculatorpage.js | 2 +- gsa/src/web/pages/extras/feedstatuspage.js | 4 ++-- gsa/src/web/pages/extras/trashcanpage.js | 6 +++++- gsa/src/web/pages/filters/detailspage.js | 4 ++-- gsa/src/web/pages/filters/listpage.js | 6 +++++- gsa/src/web/pages/groups/detailspage.js | 6 +++--- gsa/src/web/pages/groups/listpage.js | 4 ++-- gsa/src/web/pages/hosts/detailspage.js | 6 +++--- gsa/src/web/pages/hosts/listpage.js | 4 ++-- gsa/src/web/pages/ldap/ldappage.js | 2 +- gsa/src/web/pages/notes/detailspage.js | 4 ++-- gsa/src/web/pages/notes/listpage.js | 4 ++-- gsa/src/web/pages/nvts/detailspage.js | 4 ++-- gsa/src/web/pages/nvts/listpage.js | 4 ++-- gsa/src/web/pages/operatingsystems/detailspage.js | 4 ++-- gsa/src/web/pages/operatingsystems/listpage.js | 4 ++-- gsa/src/web/pages/ovaldefs/detailspage.js | 4 ++-- gsa/src/web/pages/ovaldefs/listpage.js | 4 ++-- gsa/src/web/pages/overrides/detailspage.js | 4 ++-- gsa/src/web/pages/overrides/listpage.js | 4 ++-- gsa/src/web/pages/performance/performancepage.js | 2 +- gsa/src/web/pages/permissions/detailspage.js | 4 ++-- gsa/src/web/pages/permissions/listpage.js | 4 ++-- gsa/src/web/pages/portlists/detailspage.js | 6 +++--- gsa/src/web/pages/portlists/listpage.js | 4 ++-- gsa/src/web/pages/radius/radiuspage.js | 2 +- gsa/src/web/pages/reportformats/detailspage.js | 4 ++-- gsa/src/web/pages/reportformats/listpage.js | 2 +- gsa/src/web/pages/reports/detailscontent.js | 6 +++--- gsa/src/web/pages/reports/listpage.js | 4 ++-- gsa/src/web/pages/results/detailspage.js | 4 ++-- gsa/src/web/pages/results/listpage.js | 4 ++-- gsa/src/web/pages/roles/detailspage.js | 4 ++-- gsa/src/web/pages/roles/listpage.js | 4 ++-- gsa/src/web/pages/scanconfigs/detailspage.js | 4 ++-- gsa/src/web/pages/scanconfigs/listpage.js | 4 ++-- gsa/src/web/pages/scanners/detailspage.js | 4 ++-- gsa/src/web/pages/scanners/listpage.js | 4 ++-- gsa/src/web/pages/schedules/detailspage.js | 4 ++-- gsa/src/web/pages/schedules/listpage.js | 4 ++-- gsa/src/web/pages/secinfo/listpage.js | 3 +-- gsa/src/web/pages/tags/detailspage.js | 4 ++-- gsa/src/web/pages/tags/listpage.js | 6 +++++- gsa/src/web/pages/targets/detailspage.js | 4 ++-- gsa/src/web/pages/targets/listpage.js | 4 ++-- gsa/src/web/pages/tasks/detailspage.js | 4 ++-- gsa/src/web/pages/tasks/listpage.js | 4 ++-- gsa/src/web/pages/tickets/detailspage.js | 6 ++++++ gsa/src/web/pages/tickets/listpage.js | 10 ++++++++++ gsa/src/web/pages/users/detailspage.js | 6 +++--- gsa/src/web/pages/users/listpage.js | 4 ++-- gsa/src/web/pages/usersettings/usersettingspage.js | 4 ++-- gsa/src/web/pages/vulns/listpage.js | 4 ++-- 65 files changed, 146 insertions(+), 127 deletions(-) diff --git a/gsa/src/web/pages/alerts/detailspage.js b/gsa/src/web/pages/alerts/detailspage.js index d7f155425d..14afd13ff9 100644 --- a/gsa/src/web/pages/alerts/detailspage.js +++ b/gsa/src/web/pages/alerts/detailspage.js @@ -73,8 +73,8 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/alerts/listpage.js b/gsa/src/web/pages/alerts/listpage.js index 897273e788..60e27181f2 100644 --- a/gsa/src/web/pages/alerts/listpage.js +++ b/gsa/src/web/pages/alerts/listpage.js @@ -48,8 +48,8 @@ import AlertTable, {SORT_FIELDS} from './table.js'; const ToolBarIcons = withCapabilities(({capabilities, onAlertCreateClick}) => ( {capabilities.mayCreate('alert') && ( diff --git a/gsa/src/web/pages/certbund/detailspage.js b/gsa/src/web/pages/certbund/detailspage.js index cc01036437..a34d9346fa 100644 --- a/gsa/src/web/pages/certbund/detailspage.js +++ b/gsa/src/web/pages/certbund/detailspage.js @@ -66,8 +66,8 @@ const ToolBarIcons = ({entity, onCertBundAdvDownloadClick}) => ( diff --git a/gsa/src/web/pages/certbund/listpage.js b/gsa/src/web/pages/certbund/listpage.js index 67a424acb6..4a1a34ded0 100644 --- a/gsa/src/web/pages/certbund/listpage.js +++ b/gsa/src/web/pages/certbund/listpage.js @@ -44,8 +44,8 @@ import CertBundDashboard, {CERTBUND_DASHBOARD_ID} from './dashboard'; const ToolBarIcons = props => ( ); diff --git a/gsa/src/web/pages/cpes/detailspage.js b/gsa/src/web/pages/cpes/detailspage.js index 6f84750fed..4a7c89ed7b 100644 --- a/gsa/src/web/pages/cpes/detailspage.js +++ b/gsa/src/web/pages/cpes/detailspage.js @@ -66,7 +66,7 @@ const ToolBarIcons = ({entity, onCpeDownloadClick}) => ( diff --git a/gsa/src/web/pages/cpes/listpage.js b/gsa/src/web/pages/cpes/listpage.js index 241a430ac3..bc697d675b 100644 --- a/gsa/src/web/pages/cpes/listpage.js +++ b/gsa/src/web/pages/cpes/listpage.js @@ -43,11 +43,7 @@ import CpesTable from './table'; import CpesDashboard, {CPES_DASHBOARD_ID} from './dashboard'; const ToolBarIcons = props => ( - + ); const Page = ({filter, onFilterChanged, onInteraction, ...props}) => ( diff --git a/gsa/src/web/pages/credentials/detailspage.js b/gsa/src/web/pages/credentials/detailspage.js index 10dc0b9dfc..acfb87be5b 100644 --- a/gsa/src/web/pages/credentials/detailspage.js +++ b/gsa/src/web/pages/credentials/detailspage.js @@ -91,8 +91,8 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/credentials/listpage.js b/gsa/src/web/pages/credentials/listpage.js index 3628594647..516e92ac3b 100644 --- a/gsa/src/web/pages/credentials/listpage.js +++ b/gsa/src/web/pages/credentials/listpage.js @@ -48,8 +48,8 @@ const ToolBarIcons = withCapabilities( ({capabilities, onCredentialCreateClick}) => ( {capabilities.mayCreate('credential') && ( diff --git a/gsa/src/web/pages/cves/detailspage.js b/gsa/src/web/pages/cves/detailspage.js index bbaa6f6e63..1c92033771 100644 --- a/gsa/src/web/pages/cves/detailspage.js +++ b/gsa/src/web/pages/cves/detailspage.js @@ -65,7 +65,7 @@ const ToolBarIcons = ({entity, onCveDownloadClick}) => ( diff --git a/gsa/src/web/pages/cves/listpage.js b/gsa/src/web/pages/cves/listpage.js index 2c57a03183..4eafa42c7a 100644 --- a/gsa/src/web/pages/cves/listpage.js +++ b/gsa/src/web/pages/cves/listpage.js @@ -43,11 +43,7 @@ import CvesTable from './table'; import CvesDashboard, {CVES_DASHBOARD_ID} from './dashboard'; const ToolBarIcons = () => ( - + ); const Page = ({filter, onFilterChanged, onInteraction, ...props}) => ( diff --git a/gsa/src/web/pages/dfncert/detailspage.js b/gsa/src/web/pages/dfncert/detailspage.js index dd97ecac86..94c995ebeb 100644 --- a/gsa/src/web/pages/dfncert/detailspage.js +++ b/gsa/src/web/pages/dfncert/detailspage.js @@ -58,8 +58,8 @@ const ToolBarIcons = ({entity, onDfnCertAdvDownloadClick}) => ( diff --git a/gsa/src/web/pages/dfncert/listpage.js b/gsa/src/web/pages/dfncert/listpage.js index 2cd8a60c37..f1eb2ea8fb 100644 --- a/gsa/src/web/pages/dfncert/listpage.js +++ b/gsa/src/web/pages/dfncert/listpage.js @@ -46,8 +46,8 @@ import DfnCertDashboard, {DFNCERT_DASHBOARD_ID} from './dashboard'; const ToolBarIcons = () => ( ); diff --git a/gsa/src/web/pages/extras/cvsscalculatorpage.js b/gsa/src/web/pages/extras/cvsscalculatorpage.js index 6ecba192a6..6d06dc0b83 100644 --- a/gsa/src/web/pages/extras/cvsscalculatorpage.js +++ b/gsa/src/web/pages/extras/cvsscalculatorpage.js @@ -54,7 +54,7 @@ const StyledTextField = styled(TextField)` const ToolBarIcons = () => ( ( diff --git a/gsa/src/web/pages/extras/trashcanpage.js b/gsa/src/web/pages/extras/trashcanpage.js index ef6e0286e0..f02397bd98 100644 --- a/gsa/src/web/pages/extras/trashcanpage.js +++ b/gsa/src/web/pages/extras/trashcanpage.js @@ -82,7 +82,11 @@ const Col = styled.col` `; const ToolBarIcons = () => ( - + ); const EmptyTrashButton = withCapabilities(({onClick, capabilities}) => { diff --git a/gsa/src/web/pages/filters/detailspage.js b/gsa/src/web/pages/filters/detailspage.js index beab487e9c..94229c34d3 100644 --- a/gsa/src/web/pages/filters/detailspage.js +++ b/gsa/src/web/pages/filters/detailspage.js @@ -73,8 +73,8 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/filters/listpage.js b/gsa/src/web/pages/filters/listpage.js index 8aeae4feda..48805782d7 100644 --- a/gsa/src/web/pages/filters/listpage.js +++ b/gsa/src/web/pages/filters/listpage.js @@ -46,7 +46,11 @@ import FiltersTable, {SORT_FIELDS} from './table'; const ToolBarIcons = withCapabilities(({capabilities, onFilterCreateClick}) => ( - + {capabilities.mayCreate('filter') && ( )} diff --git a/gsa/src/web/pages/groups/detailspage.js b/gsa/src/web/pages/groups/detailspage.js index 22ff724f1d..fef94be44d 100644 --- a/gsa/src/web/pages/groups/detailspage.js +++ b/gsa/src/web/pages/groups/detailspage.js @@ -73,9 +73,9 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/groups/listpage.js b/gsa/src/web/pages/groups/listpage.js index 173527b76b..1a342b2868 100644 --- a/gsa/src/web/pages/groups/listpage.js +++ b/gsa/src/web/pages/groups/listpage.js @@ -47,8 +47,8 @@ import Table, {SORT_FIELDS} from './table'; const ToolBarIcons = withCapabilities(({capabilities, onGroupCreateClick}) => ( {capabilities.mayCreate('group') && ( diff --git a/gsa/src/web/pages/hosts/detailspage.js b/gsa/src/web/pages/hosts/detailspage.js index 93078e5e2a..12db7be0b1 100644 --- a/gsa/src/web/pages/hosts/detailspage.js +++ b/gsa/src/web/pages/hosts/detailspage.js @@ -93,9 +93,9 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/hosts/listpage.js b/gsa/src/web/pages/hosts/listpage.js index c281a63e92..f5383e3c8f 100644 --- a/gsa/src/web/pages/hosts/listpage.js +++ b/gsa/src/web/pages/hosts/listpage.js @@ -52,8 +52,8 @@ import HostsDashboard, {HOSTS_DASHBOARD_ID} from './dashboard'; const ToolBarIcons = withCapabilities(({capabilities, onHostCreateClick}) => ( {capabilities.mayCreate('host') && ( diff --git a/gsa/src/web/pages/ldap/ldappage.js b/gsa/src/web/pages/ldap/ldappage.js index 34f7856f0c..1aa7d1ab57 100644 --- a/gsa/src/web/pages/ldap/ldappage.js +++ b/gsa/src/web/pages/ldap/ldappage.js @@ -53,7 +53,7 @@ import LdapDialog from './dialog'; const ToolBarIcons = ({onOpenDialogClick}) => ( diff --git a/gsa/src/web/pages/notes/listpage.js b/gsa/src/web/pages/notes/listpage.js index dcf367c38e..74fc2fbfc6 100644 --- a/gsa/src/web/pages/notes/listpage.js +++ b/gsa/src/web/pages/notes/listpage.js @@ -50,8 +50,8 @@ import NoteIcon from 'web/components/icon/noteicon'; const ToolBarIcons = withCapabilities(({capabilities, onNoteCreateClick}) => ( {capabilities.mayCreate('note') && ( diff --git a/gsa/src/web/pages/nvts/detailspage.js b/gsa/src/web/pages/nvts/detailspage.js index 42dde76f04..b5ce41e2b1 100644 --- a/gsa/src/web/pages/nvts/detailspage.js +++ b/gsa/src/web/pages/nvts/detailspage.js @@ -82,8 +82,8 @@ let ToolBarIcons = ({ diff --git a/gsa/src/web/pages/nvts/listpage.js b/gsa/src/web/pages/nvts/listpage.js index 74d49db4ff..eb8670f94a 100644 --- a/gsa/src/web/pages/nvts/listpage.js +++ b/gsa/src/web/pages/nvts/listpage.js @@ -44,8 +44,8 @@ import NvtsDashboard, {NVTS_DASHBOARD_ID} from './dashboard'; const ToolBarIcons = () => ( ); diff --git a/gsa/src/web/pages/operatingsystems/detailspage.js b/gsa/src/web/pages/operatingsystems/detailspage.js index adafdba27b..c0e9ef58e2 100644 --- a/gsa/src/web/pages/operatingsystems/detailspage.js +++ b/gsa/src/web/pages/operatingsystems/detailspage.js @@ -86,8 +86,8 @@ let ToolBarIcons = ({ diff --git a/gsa/src/web/pages/operatingsystems/listpage.js b/gsa/src/web/pages/operatingsystems/listpage.js index 0af31bb9d6..cf873930f5 100644 --- a/gsa/src/web/pages/operatingsystems/listpage.js +++ b/gsa/src/web/pages/operatingsystems/listpage.js @@ -48,8 +48,8 @@ import OsDashboard, {OS_DASHBOARD_ID} from './dashboard'; const ToolBarIcons = () => ( diff --git a/gsa/src/web/pages/ovaldefs/detailspage.js b/gsa/src/web/pages/ovaldefs/detailspage.js index cd00c1311a..85c8a9b9eb 100644 --- a/gsa/src/web/pages/ovaldefs/detailspage.js +++ b/gsa/src/web/pages/ovaldefs/detailspage.js @@ -69,8 +69,8 @@ const ToolBarIcons = ({entity, onOvaldefDownloadClick}) => ( diff --git a/gsa/src/web/pages/ovaldefs/listpage.js b/gsa/src/web/pages/ovaldefs/listpage.js index 3dfde3e381..e3761f9886 100644 --- a/gsa/src/web/pages/ovaldefs/listpage.js +++ b/gsa/src/web/pages/ovaldefs/listpage.js @@ -44,8 +44,8 @@ import OvaldefDashboard, {OVALDEF_DASHBOARD_ID} from './dashboard'; const ToolBarIcons = () => ( ); diff --git a/gsa/src/web/pages/overrides/detailspage.js b/gsa/src/web/pages/overrides/detailspage.js index fd67162274..1832fe23ec 100644 --- a/gsa/src/web/pages/overrides/detailspage.js +++ b/gsa/src/web/pages/overrides/detailspage.js @@ -92,8 +92,8 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/overrides/listpage.js b/gsa/src/web/pages/overrides/listpage.js index f66f34ce5c..72237bc1a1 100644 --- a/gsa/src/web/pages/overrides/listpage.js +++ b/gsa/src/web/pages/overrides/listpage.js @@ -51,8 +51,8 @@ const ToolBarIcons = withCapabilities( ({capabilities, onOverrideCreateClick}) => ( diff --git a/gsa/src/web/pages/performance/performancepage.js b/gsa/src/web/pages/performance/performancepage.js index adef08f640..f62e138213 100644 --- a/gsa/src/web/pages/performance/performancepage.js +++ b/gsa/src/web/pages/performance/performancepage.js @@ -83,7 +83,7 @@ const ToolBar = ({onDurationChangeClick}) => { diff --git a/gsa/src/web/pages/permissions/detailspage.js b/gsa/src/web/pages/permissions/detailspage.js index dcc80bd378..01b657e26a 100644 --- a/gsa/src/web/pages/permissions/detailspage.js +++ b/gsa/src/web/pages/permissions/detailspage.js @@ -65,8 +65,8 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/permissions/listpage.js b/gsa/src/web/pages/permissions/listpage.js index 47f3eb364f..977f2c4a7f 100644 --- a/gsa/src/web/pages/permissions/listpage.js +++ b/gsa/src/web/pages/permissions/listpage.js @@ -49,8 +49,8 @@ const ToolBarIcons = withCapabilities( ({capabilities, onPermissionCreateClick}) => ( {capabilities.mayCreate('permission') && ( diff --git a/gsa/src/web/pages/portlists/detailspage.js b/gsa/src/web/pages/portlists/detailspage.js index 95fea34f4c..ecf1b68dbd 100644 --- a/gsa/src/web/pages/portlists/detailspage.js +++ b/gsa/src/web/pages/portlists/detailspage.js @@ -74,9 +74,9 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/portlists/listpage.js b/gsa/src/web/pages/portlists/listpage.js index a634c9c80c..d0c77ee53b 100644 --- a/gsa/src/web/pages/portlists/listpage.js +++ b/gsa/src/web/pages/portlists/listpage.js @@ -48,8 +48,8 @@ const ToolBarIcons = withCapabilities( ({capabilities, onPortListCreateClick, onPortListImportClick}) => ( {capabilities.mayCreate('port_list') && ( diff --git a/gsa/src/web/pages/radius/radiuspage.js b/gsa/src/web/pages/radius/radiuspage.js index 49dfd1eb2f..c2779303dc 100644 --- a/gsa/src/web/pages/radius/radiuspage.js +++ b/gsa/src/web/pages/radius/radiuspage.js @@ -53,7 +53,7 @@ import RadiusDialog from './dialog'; const ToolBarIcons = ({onOpenDialogClick}) => ( diff --git a/gsa/src/web/pages/reportformats/listpage.js b/gsa/src/web/pages/reportformats/listpage.js index 5367ef6ffe..e861928120 100644 --- a/gsa/src/web/pages/reportformats/listpage.js +++ b/gsa/src/web/pages/reportformats/listpage.js @@ -49,7 +49,7 @@ const ToolBarIcons = withCapabilities( {capabilities.mayCreate('report_format') && ( diff --git a/gsa/src/web/pages/reports/detailscontent.js b/gsa/src/web/pages/reports/detailscontent.js index ae54f317f0..8f80512fb4 100644 --- a/gsa/src/web/pages/reports/detailscontent.js +++ b/gsa/src/web/pages/reports/detailscontent.js @@ -149,9 +149,9 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/reports/listpage.js b/gsa/src/web/pages/reports/listpage.js index 259539923b..8270015f93 100644 --- a/gsa/src/web/pages/reports/listpage.js +++ b/gsa/src/web/pages/reports/listpage.js @@ -68,8 +68,8 @@ const CONTAINER_TASK_FILTER = Filter.fromString('target=""'); const ToolBarIcons = ({onUploadReportClick}) => ( diff --git a/gsa/src/web/pages/results/detailspage.js b/gsa/src/web/pages/results/detailspage.js index 13fb24a494..953c16a8c2 100644 --- a/gsa/src/web/pages/results/detailspage.js +++ b/gsa/src/web/pages/results/detailspage.js @@ -102,8 +102,8 @@ let ToolBarIcons = ({ diff --git a/gsa/src/web/pages/results/listpage.js b/gsa/src/web/pages/results/listpage.js index a5c61eb6b9..2a4ff35cc8 100644 --- a/gsa/src/web/pages/results/listpage.js +++ b/gsa/src/web/pages/results/listpage.js @@ -46,8 +46,8 @@ import ResultsDashboard, {RESULTS_DASHBOARD_ID} from './dashboard'; const ToolBarIcons = () => ( diff --git a/gsa/src/web/pages/roles/detailspage.js b/gsa/src/web/pages/roles/detailspage.js index 2361daa6d8..934e1075bf 100644 --- a/gsa/src/web/pages/roles/detailspage.js +++ b/gsa/src/web/pages/roles/detailspage.js @@ -85,8 +85,8 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/roles/listpage.js b/gsa/src/web/pages/roles/listpage.js index f976edd005..4061267534 100644 --- a/gsa/src/web/pages/roles/listpage.js +++ b/gsa/src/web/pages/roles/listpage.js @@ -47,8 +47,8 @@ import Table, {SORT_FIELDS} from './table'; const ToolBarIcons = withCapabilities(({capabilities, onRoleCreateClick}) => ( {capabilities.mayCreate('role') && ( diff --git a/gsa/src/web/pages/scanconfigs/detailspage.js b/gsa/src/web/pages/scanconfigs/detailspage.js index 0a4b50b2f8..a259ea174e 100644 --- a/gsa/src/web/pages/scanconfigs/detailspage.js +++ b/gsa/src/web/pages/scanconfigs/detailspage.js @@ -92,8 +92,8 @@ const ToolBarIcons = withCapabilities( diff --git a/gsa/src/web/pages/scanconfigs/listpage.js b/gsa/src/web/pages/scanconfigs/listpage.js index 61e134e2a0..5a9d6dddd1 100644 --- a/gsa/src/web/pages/scanconfigs/listpage.js +++ b/gsa/src/web/pages/scanconfigs/listpage.js @@ -49,8 +49,8 @@ const ToolBarIcons = withCapabilities( ({capabilities, onScanConfigCreateClick, onScanConfigImportClick}) => ( {capabilities.mayCreate('config') && ( diff --git a/gsa/src/web/pages/scanners/detailspage.js b/gsa/src/web/pages/scanners/detailspage.js index f9b09a587d..f780e2ba21 100644 --- a/gsa/src/web/pages/scanners/detailspage.js +++ b/gsa/src/web/pages/scanners/detailspage.js @@ -83,8 +83,8 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/scanners/listpage.js b/gsa/src/web/pages/scanners/listpage.js index 28a62a3cc2..e075dbf91d 100644 --- a/gsa/src/web/pages/scanners/listpage.js +++ b/gsa/src/web/pages/scanners/listpage.js @@ -48,8 +48,8 @@ const ToolBarIcons = withCapabilities( ({capabilities, onScannerCreateClick}) => ( {capabilities.mayCreate('scanner') && ( diff --git a/gsa/src/web/pages/schedules/detailspage.js b/gsa/src/web/pages/schedules/detailspage.js index 26cf665e46..1b0765c127 100644 --- a/gsa/src/web/pages/schedules/detailspage.js +++ b/gsa/src/web/pages/schedules/detailspage.js @@ -73,8 +73,8 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/schedules/listpage.js b/gsa/src/web/pages/schedules/listpage.js index 0d64e5aa1e..28d91e06b8 100644 --- a/gsa/src/web/pages/schedules/listpage.js +++ b/gsa/src/web/pages/schedules/listpage.js @@ -48,8 +48,8 @@ const ToolBarIcons = withCapabilities( ({capabilities, onScheduleCreateClick}) => ( {capabilities.mayCreate('schedule') && ( diff --git a/gsa/src/web/pages/secinfo/listpage.js b/gsa/src/web/pages/secinfo/listpage.js index 7427f80ec3..d886cc6c1b 100644 --- a/gsa/src/web/pages/secinfo/listpage.js +++ b/gsa/src/web/pages/secinfo/listpage.js @@ -44,8 +44,7 @@ import {SecInfoDashboard, SECINFO_DASHBOARD_ID} from './dashboard'; const ToolBarIcons = () => ( ); diff --git a/gsa/src/web/pages/tags/detailspage.js b/gsa/src/web/pages/tags/detailspage.js index 70fa0d6762..df2066e4eb 100644 --- a/gsa/src/web/pages/tags/detailspage.js +++ b/gsa/src/web/pages/tags/detailspage.js @@ -103,8 +103,8 @@ const ToolBarIcons = withCapabilties( diff --git a/gsa/src/web/pages/tags/listpage.js b/gsa/src/web/pages/tags/listpage.js index 8983eb405a..d8f9157c28 100644 --- a/gsa/src/web/pages/tags/listpage.js +++ b/gsa/src/web/pages/tags/listpage.js @@ -74,7 +74,11 @@ export const SORT_FIELDS = [ const ToolBarIcons = withCapabilities(({capabilities, onTagCreateClick}) => ( - + {capabilities.mayCreate('tag') && ( )} diff --git a/gsa/src/web/pages/targets/detailspage.js b/gsa/src/web/pages/targets/detailspage.js index 797488925e..0232d92feb 100644 --- a/gsa/src/web/pages/targets/detailspage.js +++ b/gsa/src/web/pages/targets/detailspage.js @@ -84,8 +84,8 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/targets/listpage.js b/gsa/src/web/pages/targets/listpage.js index f884a724a2..ec1a487550 100644 --- a/gsa/src/web/pages/targets/listpage.js +++ b/gsa/src/web/pages/targets/listpage.js @@ -46,8 +46,8 @@ import TargetComponent from './component'; const ToolBarIcons = withCapabilities(({capabilities, onTargetCreateClick}) => ( {capabilities.mayCreate('target') && ( diff --git a/gsa/src/web/pages/tasks/detailspage.js b/gsa/src/web/pages/tasks/detailspage.js index afc29c032b..e079b86863 100644 --- a/gsa/src/web/pages/tasks/detailspage.js +++ b/gsa/src/web/pages/tasks/detailspage.js @@ -125,8 +125,8 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/tasks/listpage.js b/gsa/src/web/pages/tasks/listpage.js index d7e4073ca0..ce2a2cae2e 100644 --- a/gsa/src/web/pages/tasks/listpage.js +++ b/gsa/src/web/pages/tasks/listpage.js @@ -64,8 +64,8 @@ const ToolBarIcons = withCapabilities( }) => ( {capabilities.mayOp('run_wizard') && ( diff --git a/gsa/src/web/pages/tickets/detailspage.js b/gsa/src/web/pages/tickets/detailspage.js index af950fcf12..bbc9310b3e 100644 --- a/gsa/src/web/pages/tickets/detailspage.js +++ b/gsa/src/web/pages/tickets/detailspage.js @@ -28,6 +28,7 @@ import Comment from 'web/components/comment/comment'; import ExportIcon from 'web/components/icon/exporticon'; import ListIcon from 'web/components/icon/listicon'; +import ManualIcon from 'web/components/icon/manualicon'; import SolutionType from 'web/components/icon/solutiontypeicon'; import TicketIcon from 'web/components/icon/ticketicon'; @@ -77,6 +78,11 @@ const ToolBarIcons = ({ onTicketEditClick, }) => ( + ( + +); + const Page = ({ filter, onFilterChanged, @@ -92,6 +101,7 @@ const Page = ({ sectionIcon={} table={Table} title={_('Tickets')} + toolBarIcons={ToolBarIcons} onChanged={onChanged} onError={onError} onFilterChanged={onFilterChanged} diff --git a/gsa/src/web/pages/users/detailspage.js b/gsa/src/web/pages/users/detailspage.js index 8cc79452da..0d015c8e43 100644 --- a/gsa/src/web/pages/users/detailspage.js +++ b/gsa/src/web/pages/users/detailspage.js @@ -73,9 +73,9 @@ const ToolBarIcons = ({ diff --git a/gsa/src/web/pages/users/listpage.js b/gsa/src/web/pages/users/listpage.js index f757c5e3bf..bca80629b3 100644 --- a/gsa/src/web/pages/users/listpage.js +++ b/gsa/src/web/pages/users/listpage.js @@ -58,8 +58,8 @@ import UsersTable, {SORT_FIELDS} from './table'; const ToolBarIcons = withCapabilities(({capabilities, onUserCreateClick}) => ( {capabilities.mayCreate('user') && ( diff --git a/gsa/src/web/pages/usersettings/usersettingspage.js b/gsa/src/web/pages/usersettings/usersettingspage.js index c0a4aa3ae5..7ee15a3e35 100644 --- a/gsa/src/web/pages/usersettings/usersettingspage.js +++ b/gsa/src/web/pages/usersettings/usersettingspage.js @@ -165,8 +165,8 @@ const ToolBarIcons = ({disableEditIcon, onEditSettingsClick}) => ( ( From 2f83a62b36bb3a6c6611c66027cbcf7493343246 Mon Sep 17 00:00:00 2001 From: Steffen Waterkamp Date: Tue, 6 Aug 2019 19:01:11 +0200 Subject: [PATCH 4/4] Update Changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index bfb8782d88..2875054c0c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). [#1507](https://github.com/greenbone/gsa/pull/1507) ### Changed +- Adjust HelpIcons to use GOS 5 manual [#1549](https://github.com/greenbone/gsa/pull/1549) - Adjust clickable areas for Select and MultiSelect [#1545](https://github.com/greenbone/gsa/pull/1545) - Redirect to main page when visiting the login page and the user is already logged in [#1508](https://github.com/greenbone/gsa/pull/1508)