Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firmware: handle zero-length-packets manually for the out control endpoint #287

Merged

Conversation

Qyriad
Copy link
Contributor

@Qyriad Qyriad commented Sep 16, 2019

Copy link
Contributor

@ktemkin ktemkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message here should indicate that this is

  1. for GreatDancer (ZLTs are still automatically generated for normal-USB EP0)
  2. the commit message should probably be shorter

@ktemkin
Copy link
Contributor

ktemkin commented Sep 16, 2019

The commit could probably use an explanation in the commit message, too. Something explain why Linux is silly would be good. ;)

Another question to be answered is if we should have a paralleling change in the normal firmware. I suspect we suffer exactly the same issue (we don't accept packets from OS's cough Linux cough that don't properly generate ZLPs at the end of their OUT control requests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USB packets that are 64 byte aligned in data size are not forwarded through the usbproxy on the GreatFET One
2 participants