gateware.flash_bridge: fix port in platforms that share it with Apollo #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new apollo_gateware_phy property introduced in greatscottgadgets/luna#269.
martinling
approved these changes
Jul 5, 2024
mossmann
approved these changes
Jul 5, 2024
|
@mndza Is there any reason for this to still be a draft now that greatscottgadgets/luna#269 is merged? |
|
Ha! You took it out of draft while I was typing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new
apollo_gateware_phyproperty introduced in greatscottgadgets/luna#269.Fixes #94.