Endpoint/Interface specific Requests were not handled by correct handler function #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The to_this_endpoint() decorator based on the _wrap_with_field_matcher() helper did not compare the requests index against the endpoints address but against the static value 0b10001111.
…multiple interfaces The to_this_interface() decorator based on the _wrap_with_field_matcher() did not check the "index" field of the request. Thus always the first interfaces request handler was run.
USBDevice.handle_generic_get_descriptor_request() is called from USBInterface and USBDevice. Both callers passed themself as "self", which is technicially not correct, as "self" always has to be of type USBDevice. Now the signature is changed, so that it shows all possible types correctly.
Closed
|
Great catch, thank you for the PR! Merged in facedancer-v3 branch: antoinevg#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests that are Endpoint/Interface specific did not call the handler method within the corresponding USBEndpoint/USBInterface object. Usually these handler methods are decorated by
@to_this_endpointor@to_this_interface. But both decorators did not work as expected:This is for example problematic when implementing a composite usb device consisting of i.e. two independent HID devices (both providing a REPORT descriptor). The GetDescriptor command for retrieving the REPORT descriptor will always return the REPORT descriptor of the first interface (no matter what index parameter is passed).