Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Project Dolphin - Magento 2 Github Codespaces #64

Merged
merged 13 commits into from
Aug 4, 2022
Merged

feat: Project Dolphin - Magento 2 Github Codespaces #64

merged 13 commits into from
Aug 4, 2022

Conversation

MateusDadalto
Copy link
Contributor

@MateusDadalto MateusDadalto commented Aug 4, 2022 •
edited by damienwebdev
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

See #42

Fixes: #42

What is the new behavior?

See #42 #39

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGES

This is currently non-breaking, but will become breaking in the future. Devs are encouraged to start using the Dolphin environment.

damienwebdev and others added 12 commits August 4, 2022 14:18
@damienwebdev
feat(nginx): add auto-reloading (#64)
8637597
@damienwebdev @MateusDadalto
feat(php): add new dolphin base images for php 7.2, 7.3, and 7.4 (#64)
db7a950 
Co-authored-by: Mateus Dutra Dadalto <[email protected]>
@damienwebdev
feat(env): add revised ENV for dolphin (#64)
9020d1e
@damienwebdev
feat(sync): add new container sync strategy (#64)
35fe4db
@damienwebdev @MateusDadalto
ci: add new docker image publish for dolphin images (#64)
93723f8 
Co-authored-by: Mateus Dutra Dadalto <[email protected]>
@damienwebdev
build: add nice recommendations for working on Mage2Docker (#64)
29852a8
@damienwebdev @MateusDadalto @Nolan-Arnold
feat(php): add, use new configurations for dolphin php (#64)
d4d1c78 
BREAKING CHANGES: the base image for most environments has changed from
alpine-develop to dolphin, which is still alpine based. Most thing
should work the same, but this could be breaking for you.

Co-authored-by: Mateus Dutra Dadalto <[email protected]>
Co-authored-by: Nolan Arnold <[email protected]>
@damienwebdev @Nolan-Arnold
fix: dont restart mysql always, only on failure (#44)
c999ac2 
Co-authored-by: Nolan Arnold <[email protected]>
@damienwebdev @MateusDadalto
test: add a CI pipeline to verify that installation works (#64)
ba7ca69 
Co-authored-by: Mateus Dutra Dadalto <[email protected]>
@damienwebdev @MateusDadalto
feat: add a devcontainer.json that uses dolphin (#64)
708fbe7 
Co-authored-by: Mateus Dutra Dadalto <[email protected]>
@damienwebdev
docs: revise docs for dolphin (#64)
064e3d7
@damienwebdev
docs: revise docs for dolphin (#64)
9e06ad4
@damienwebdev damienwebdev marked this pull request as ready for review August 4, 2022 18:31
@damienwebdev damienwebdev self-requested a review as a code owner August 4, 2022 18:31
@damienwebdev damienwebdev changed the title Dolphin feat: Project Dolphin - Magento 2 Github Codespaces Aug 4, 2022
@damienwebdev damienwebdev merged commit 7e66c42 into master Aug 4, 2022
@damienwebdev damienwebdev deleted the dolphin-rebased branch August 4, 2022 18:39
@damienwebdev damienwebdev mentioned this pull request Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienwebdev damienwebdev Awaiting requested review from damienwebdev damienwebdev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Devcontainers Support in VSCode (Dolphin)
2 participants
@MateusDadalto @damienwebdev