Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: lint file names #75

Merged
merged 4 commits into from
Aug 7, 2022
Merged

ci: lint file names #75

merged 4 commits into from
Aug 7, 2022

Conversation

damienwebdev
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, we have both yaml and yml in the codebase. While yaml is apparently more correct, most of the docker ecosystem uses yml. This is what happens when you don't mandate a convention upfront.

Fixes: #62 #63

What is the new behavior?

We only allow yml files.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

If you have a compose file with yaml, you should change it to yml

Other information

@damienwebdev damienwebdev merged commit 4e2d333 into master Aug 7, 2022
@damienwebdev damienwebdev deleted the only_yml branch August 7, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a linter for yml files in Mage2Docker
1 participant