Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Linting rules for describe() depth in tests #122

Open
damienwebdev opened this issue Nov 9, 2018 · 1 comment · May be fixed by #3056
Open

[FEAT] Linting rules for describe() depth in tests #122

damienwebdev opened this issue Nov 9, 2018 · 1 comment · May be fixed by #3056
Assignees
@damienwebdev @gracetxgao
Labels
feat a new feature, enhancement, or improvement p3 low priority

Comments

@damienwebdev
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior

Currently, tests don't follow well defined patterns or style guides.

Expected behavior

That tests follow well designed patterns and style guides.

What is the motivation / use case for changing the behavior?

As a start, in addition to the Angular styleguide rules, it would be nice if we could enforce a "describe" depth of 3, which would allow us to do meta-analysis of the complexity of a piece of code.
@damienwebdev damienwebdev added the feat a new feature, enhancement, or improvement label Nov 9, 2018
@damienwebdev damienwebdev added this to the v2.0.0 milestone Nov 9, 2018
@damienwebdev damienwebdev self-assigned this Nov 9, 2018
@damienwebdev damienwebdev added the status: frozen This code is useful, but unusable without major changes label Nov 9, 2018
@damienwebdev damienwebdev removed the status: frozen This code is useful, but unusable without major changes label Jan 31, 2019
@damienwebdev damienwebdev removed this from the v0.2.0 - The Design Package milestone Jan 31, 2019
@AnnieMi888 AnnieMi888 added the p3 low priority label Dec 20, 2023
@xelaint xelaint changed the title Feature Request: Linting rules for describe() depth in tests [FEAT] Linting rules for describe() depth in tests Dec 20, 2023
@damienwebdev
Copy link
Member Author

It looks like eslint supports this for jest. https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/max-nested-describe.md

@gracetxgao gracetxgao linked a pull request Sep 11, 2024 that will close this issue
Open
3 tasks
@damienwebdev damienwebdev linked a pull request Sep 11, 2024 that will close this issue
feat(eslint): add linting rules for test describe depth #3056
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damienwebdev damienwebdev

@gracetxgao gracetxgao

Labels
feat a new feature, enhancement, or improvement p3 low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint): add linting rules for test describe depth gracetxgao/daffodil
3 participants
@damienwebdev @gracetxgao @AnnieMi888