Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add area rendering for historic=archaeological_site #732

Closed
sabas opened this issue Jul 17, 2014 · 15 comments
Closed

Add area rendering for historic=archaeological_site #732

sabas opened this issue Jul 17, 2014 · 15 comments

Comments

@sabas
Copy link

sabas commented Jul 17, 2014

Currently (

[historic = 'archaeological_site'][zoom >= 16]::historic {
) is rendered only as a point, but it's used also to mark areas (8939 occurrences as area and 220 as relation). Is it possible to add some color fill?
To make it show I saw being often used tourism=attraction

@matkoniecz
Copy link
Contributor

@matthijsmelissen matthijsmelissen added this to the New features milestone Aug 18, 2014
@matthijsmelissen matthijsmelissen changed the title historic=archaeological_site as an area Add rendering for historic=archaeological_site Sep 24, 2014
@matkoniecz matkoniecz changed the title Add rendering for historic=archaeological_site Add area rendering for historic=archaeological_site Oct 11, 2014
@matkoniecz
Copy link
Contributor

Can you propose how it would be rendered?

@sabas
Copy link
Author

sabas commented Jan 6, 2015

A lighter version of the color used for important buildings?
Also a similar color could be applied to tourism=attraction. ( #1063 )

@matkoniecz
Copy link
Contributor

It would make it confusing, it would look like a building.

@matkoniecz
Copy link
Contributor

@sabas Where it would improve map? Can you give examples? Preferably - both screenshot and link to location on map.

I was unable to find places where it would not be solved by #1257

@sabas
Copy link
Author

sabas commented Aug 26, 2015

http://overpass-turbo.eu/s/b8y I tag a typical megalith of Sardinia island as an area when possible
http://www.openstreetmap.org/way/146036992#map=17/40.06051/8.73277 (this is a well - hole in the ground with stairs) the enclosing site is http://www.openstreetmap.org/way/146021538 . The archaeological area could be tagged as an attraction possibly, but my doubt is, would #1257 force mapping tourism=attraction for each site? Or could be added in the rule [tourism=attraction],[historic=archaeological_site] ?

@matkoniecz
Copy link
Contributor

The archaeological area could be tagged as an attraction possibly, but my doubt is, would #1257 force mapping tourism=attraction for each site?

I am hoping that all or nearly all archaeological sites worth displaying as areas are worth displaying because these places are tourism attractions. In that case it would be enough to solve #1257 without inventing additional rendering.

@imagico
Copy link
Collaborator

imagico commented Aug 26, 2015

Looking at a few world famous archaeological sites i have to say rendering the whole site in uniform color or with a boundary outline will not really improve that much:

http://www.openstreetmap.org/#map=16/27.3237/68.1332
http://www.openstreetmap.org/#map=18/35.29822/25.16244
http://www.openstreetmap.org/#map=17/39.95838/26.23999

Developing and establishing a good tagging system for archaeological remains would probably be a good idea but in general OSM mappers are more often outdoor and nature people than history buffs.

@polarbearing
Copy link
Contributor

Another case for an outline.

@mboeringa
Copy link

I am hoping that all or nearly all archaeological sites worth displaying as areas are worth displaying because these places are tourism attractions. In that case it would be enough to solve #1257 without inventing additional rendering.

I can assure you this is not always the case, because I render both tourism=attraction and historic=archaeological_site as boundary outlines. There are major historic hill forts and such tagged as historic=archaeological_site, but not necessarily as tourism attraction.

Reviewing and rendering hundreds of maps from all over the globe up to now using my renderer, this is quite clear.

It is true though, that if you actually want to limit the number of displayed archaeological sites to keep things manageable (which may not be a bad thing), then using the tourism=attraction as your sole means of displaying them, will probably weed out a lot of the lesser archaeological features. E.g. in England, I have seen dozens of underground mine shafts being tagged as areas with a historic=archaeological_site tag, where the only signs of such - mainly horizontal - shafts were their entrances and, surprisingly visible on aerial photos, vertical ventilation shafts dispersed along the length of the horizontal underground shafts.

Another case for an outline.

+1

@dan980
Copy link

dan980 commented Dec 16, 2016

This would be a great improvement in Italy, where archaeological sites are widespread. Some sites are pretty big, in this case the icon is misleading and does not give any information about the boundaries. Ironically, a cultivated field is much clearer.

@Tomasz-W
Copy link

Tomasz-W commented Jul 3, 2018

I think giving archeological sites areas a fill or outline is a bad idea and may be confusing. In most cases they don't have a physical borders (it's often a grass areas with group of stones on it). If it's a building or a walls, it should be mapped additionally as a building or a walls, then it works propetly.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 3, 2018

I think we need colors/outlines for some more generic types of areas, so I would not focus on this. Maybe if we have some system for mainstream areas (like museum/culture) it might have sense to revive it and share the rendering, but for now it seems too specific, so I'm closing it now.

@kocio-pl kocio-pl closed this as completed Jul 3, 2018
@matkoniecz
Copy link
Contributor

Even if outlines would be added for anything it would be still late in the queue (and that is assuming that outlines would be added for anything like museums).

@SomeoneElseOSM
Copy link
Contributor

SomeoneElseOSM commented Jul 3, 2018

I think giving archeological sites areas a fill or outline is a bad idea and may be confusing

It may be confusing, true (even without outlines). When I added an area rendering for them elsewhere I eventually went with a very pale pink - see here for an example (that's the western edge of this. That said, some sort of area delineation makes sense, see for example here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants