Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amenity=bench with tourism=yes/attraction tag is not rendered #5010

Closed
onovy opened this issue Aug 29, 2024 · 2 comments
Closed

amenity=bench with tourism=yes/attraction tag is not rendered #5010

onovy opened this issue Aug 29, 2024 · 2 comments

Comments

@onovy
Copy link

onovy commented Aug 29, 2024

Expected behavior

Render as amenity=bench even with tags tourism=yes or tourism=attraction

Actual behavior

Node is not rendered at all

Screenshots with links illustrating the problem

map
node
image

Thanks.

@imagico
Copy link
Collaborator

imagico commented Aug 29, 2024

Thanks for the report.

As is this issue is invalid, the feature in question is not displayed because it collides with the information board (https://www.openstreetmap.org/node/10297047800), not because of the tagging. amenity=bench with tourism=yes/tourism=attraction renders perfectly fine - see https://www.openstreetmap.org/node/10297047800, https://www.openstreetmap.org/node/11676877509. amenity=bench with tourism=attraction and name=* displays a name label for the attraction rather than a bench symbol (https://www.openstreetmap.org/node/5174053067) - which is as intended - the attraction has priority over the bench. It is generally not advisable to conflate several real world things into the same OSM element because of the ambiguous semantics (it is unclear if the name is the name of the bench or of an abstract attraction the bench happens to be located at). Us rendering name labels for tourism=attraction without further qualification has for a long time been a doubtful strategy (because it is not generally a primary tag and often abused for arbitrary label placement). I opened #5011 for that.

In the concrete case example the more suitable tagging by the way would probably be tourism=artwork (697 uses in combination with amenity=bench) or historic=memorial+memorial=bench (348 uses in combination with amenity=bench). We could think about rendering a specific symbol variation for such combinations. And the proper name would seem to be something like Lavička Jaroslava Foglara číslo X because Lavička Jaroslava Foglara is a classification (there are several of those) rather than an individual identifier.

Closing as invalid.

@imagico imagico closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
@onovy
Copy link
Author

onovy commented Aug 29, 2024

ah, thanks for really good explanation. I fixed tagging: https://www.openstreetmap.org/changeset/155925063#map=19/50.108118/14.413443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants