Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent rendering of generic taggings in case of catch-alls (shop=yes, office=yes) #4906

Open
imagico opened this issue Nov 18, 2023 · 2 comments

Comments

@imagico
Copy link
Collaborator

imagico commented Nov 18, 2023

We currently have a number of catch-all renderings in the style were we depict features with a certain key independent of the value. That in particular

  • building=*
  • shop=*
  • office=*

for building and office we do this for the value yes like for any other value while for shop we explicitly exclude shop=yes. In all three cases the yes is broadly accepted as valid tagging if a more specific classification is not available to the mapper.

IMO we should:

  • treat shop=yes and office=yes equally in that regard.
  • probably show both in a way that explicitly communicates incomplete mapping - to clearly communicate that while this is a valid value with a well defined and consistently used meaning it is not just another type of shop/office but indicates something semantically different - like highway=road for roads.

For building=yes i would not suggest a special treatment because it is so widely used without being broadly considered to be lacking more specific information.

See also #4723.

@dch0ph
Copy link
Contributor

dch0ph commented Nov 19, 2023

Above sounds reasonable.

182k shop=yes and 80k office=yes. In both cases about 70% have names.

Possible suggestions for rendering that would hint to both map user and mappers that data is incomplete:

  1. Use a lighter shade of shop / office colour for dot and any name. Using a lightened colour rather than reduced opacity might cause less semantic confusion with private access e.g. on parking.

  2. A common grey colour (as in highway=road) for "incomplete objects". This has been suggested, but probably too jarring.

@imagico
Copy link
Collaborator Author

imagico commented Nov 19, 2023

Use a lighter shade of shop / office colour for dot and any name

We already use that for access restricted POIs so it would be confusing.

A common grey colour

We already use gray dots for bollards (small) and waterway barriers (large):

https://imagico.de/map/styleinfo/#style=osmcarto&section=tags&key=barrier&value=bollard
https://imagico.de/map/styleinfo/#style=osmcarto&section=tags&key=waterway&value=lock_gate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants