Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer tag seems to be handled incorrectly sometimes at man_made=pipeline #4807

Open
Elefant-aus-Wuppertal opened this issue Apr 14, 2023 · 5 comments

Comments

@Elefant-aus-Wuppertal
Copy link

Expected behavior

Correct handling of the layer=* Tag

Actual behavior

layer-Tag seems to be not intrepreted correctly when pipelines with bridge, location and layer tags cross other linear ways:
a) another pipeline
b) a linear highway=* bridge

Screenshots with links illustrating the problem

a) Please have a look at https://www.openstreetmap.org/#map=19/51.24793/7.11005
Screenshot 2023-04-14 110100

https://www.openstreetmap.org/way/305111224/ Way 1 (tags bridge=yes, layer=1) should be rendered above https://www.openstreetmap.org/way/809936168/ Way 2. But at the highest zoom level, the opposite is true. Or am I overlooking something here?

b) A similar thing here:
Screenshot 2023-04-14 113712
https://www.openstreetmap.org/way/133902548 lays below this pipeline: https://www.openstreetmap.org/way/809936166 (tags at the pipeline: bridge=yes, location=overhead, layer=2)

But the layers seem to be treated not correctly.

Is there maybe a problem using bridge=yes and a location tag on pipelines at the same time together with layer?
Or what's the ssue?

Maybe you can help me.
Thanks a lot.

@imagico
Copy link
Collaborator

imagico commented Apr 14, 2023

We do not interpret layer=* for pipelines at the moment.

Pipelines are currently rendered in the aerialways layer - before the roads layers and are sorted according to

CASE
WHEN man_made IN ('goods_conveyor', 'pipeline') THEN 1
WHEN tags-> 'location' = 'overhead' THEN 2
WHEN bridge IS NOT NULL THEN 3
WHEN aerialway IS NOT NULL THEN 4
END

@Elefant-aus-Wuppertal
Copy link
Author

Okay, I see, thanks.

most of the overlaps between highways and man_mande=pileline also work, a few don't.

Then we have to think about how to solve it.

@Elefant-aus-Wuppertal
Copy link
Author

By the way, is it like this even possible that a man_made=pipeline gets rendered above a highway tat has a bridge tag?

@imagico
Copy link
Collaborator

imagico commented Apr 16, 2023

By the way, is it like this even possible that a man_made=pipeline gets rendered above a highway tat has a bridge tag?

Sure, you would only have to render it after the road bridges - which either requires a layer with pipeline features after the road bridges layer or to integrate pipeline rendering into the road layers.

Neither of these is simple and we do not currently have a clear consensus on the future strategy regarding roads rendering (see #172 (comment) for a summary).

@Elefant-aus-Wuppertal
Copy link
Author

I see. Thank you very much for your answer. Now I get what the issue is. I see this is a complex topic. I think it's up on you now whether to loeave this ticket open until maybe there will be some development on this topic, or close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants