Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to use unhinted Noto Arabic? #4152

Closed
mapmeld opened this issue May 30, 2020 · 7 comments
Closed

Possible to use unhinted Noto Arabic? #4152

mapmeld opened this issue May 30, 2020 · 7 comments
Labels

Comments

@mapmeld
Copy link

mapmeld commented May 30, 2020

Expected behavior

In Qalat Street (Erbil/Hawler, Iraqi Kurdistan) the ligature ڵا is not rendered correctly in the current Noto Arabic font. It's an open issue since 2018 or earlier: https://github.com/googlefonts/noto-fonts/issues/1098 - if I remember right, this and other ligatures are used a few other places in Iraq and Iran

Actual behavior

On the map: https://www.openstreetmap.org/#map=19/36.19151/44.00536 it appears as two separate characters in a U shape

Screen Shot 2020-05-30 at 5 02 16 AM

On the original GitHub issue, today someone claimed that Noto Sans Arabic unhinted doesn't have this problem. Can we use this?

@kmuncie
Copy link

kmuncie commented May 30, 2020

You may want to take a look at https://github.com/googlefonts/noto-fonts/issues/1555#issuecomment-635592028 - the latest version of unhinted Noto Sans Arabic v2.500 seems to be undergoing a large redesign according to the metadata and my testing showed a large number of regressions with diacritics in its current state.

@jeisenbe jeisenbe added the text label Jun 4, 2020
@mapmeld
Copy link
Author

mapmeld commented Oct 28, 2020

Looks like this was just fixed in Noto? But unclear to me when this change will be generally available and when OSM would update their font notofonts/noto-source#270

@nizarsq
Copy link

nizarsq commented Dec 16, 2020

This issue fixed in NotoSansArabic.

@pnorman
Copy link
Collaborator

pnorman commented Jul 8, 2022

Closing as this appears to be fixed upstream. We already have guidance on having an up-to-date version of Noto for non-latin scripts.

@pnorman pnorman closed this as completed Jul 8, 2022
@mapmeld
Copy link
Author

mapmeld commented Oct 13, 2023

I still see the issue with this character on OSM ( tile: https://tile.openstreetmap.org/19/326236/205532.png )
A new version of Noto Arabic was just released resolving this. Could it be used in future carto tile renders?
https://github.com/notofonts/arabic/releases

@imagico
Copy link
Collaborator

imagico commented Oct 14, 2023

There are essentially three possibilities here:

  1. the claim that the problem is fixed in the Noto font we use for Arabic is wrong.
  2. we screwed up the font management and end up not using the latest version of Noto for Arabic.
  3. OSMF operations did not correctly deploy the style.

Which of these applies is easy enough to figure out: Someone needs to set up the style according to our instructions and check if the problem as observed still exists. Please note that there are some differences in font handling between node-mapnik (used by kosmtik) and other mapnik bindings - see https://github.com/mapnik/node-mapnik/blob/master/lib/mapnik.js. This can lead to differences between development environments and operational deployments.

If evaluation reveals that 2. is the case please open a new issue presenting the evidence.

@imagico
Copy link
Collaborator

imagico commented Oct 16, 2023

According to openstreetmap/operations#976 it could be that the reason is the fonts on the OSMF servers have not been updated since the last style release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants