-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aeroway=parking_position tag and its label is not rendered #3869
Comments
Thank you for the report. This style currently renders Could you confirm if the features that are missing at London Gatwick Airport are tagged as |
The history explains it all: |
According to the link above, these features were previously rendered when tagged as Per to Tag:aeroway=parking_position, most of these features have the same This would lead to problems when rendering both the Is there a benefit to showing the |
There is a large benefit from displaying the parking positions - OSM is a frequently used map for airport/aircraft related applications and services as other map providers completely lack the accuracy of OSM when it comes to airports. |
While OSM might be a good source for air navigation mapping, this style is a general-purpose map. What is the use case for showing Is there a good example of a place where the parking position |
I believe this would make map complete there and it's not visually competing with other features. All the ways on the airport are not meant for general audience anyway, yet we show them, because they're big and visible. |
It would often duplicate the rendering of the ref for the nearest aeroway=gate.
It might be fine to render parking_position ways with a thinner
version of the taxiway line, but the text label rendering for the ref
for nodes and on ways may be a problem.
|
I'm not sure about refs, but some rendering of these lines is missing for me (your proposition sounds sane for me). |
What would be the steps to make OSM render the aeroways and gates for LGW again? |
We are still rendering any So this is a good example of a place where rendering the Gates are features where passengers wait for their plane - they exit through the gate to board the aircraft, so these are quite useful for general map users who want to find the way to their plane. All of these should be rendered fine currently. |
Most of the things on the airport excluding terminal are not intended for general person, including aprons and runways, so I think we can safely render them too, to have a complete set of roads with labels. Refs are also nothing special to the avionics, it's just a context for a given road. I doubt anyone would mix "A02" on terminal with "02" on road, but I see no problem rendering them later, like z18+. |
Fair enough. I'd be happy to review some test renderings, if anyone is interested in making some which show the ref and perhaps a line rendering for aeroway=parking_position at fairly high zoom levels.
|
I changed title as it is not limited to this specific airport, but about tag in the general. |
@mattyhe are you interested in fixing this issue by submitting a PR? |
Hi Joseph!
I am highly interested in fixing the issue – however my experience on GitHub and editing OSM is limited.
Are there any instructions for submitting a PR?
More than happy to do so.
|
Start out by reading CONTRIBUTING.md and INSTALL.md. If you are not using a Unix-based OS like Linux, you might prefer to start by downloading Docker and following the instructions in our file DOCKER.md, including the instruction about how to make a fork of this repository and then clone in to your system. This is usually faster and simpler. Then you can follow the guide by User @SomeoneElseOSM: "it was designed to be a step-by-step guide to what would be required, with no prior knowledge of git or github:" https://www.openstreetmap.org/user/SomeoneElse/diary/43041 If you've never used git or github before, you might need to follow a number of links in that article to find out how the do each step in detail. Here is another guide which has detailed instructions and the code you can copy and paste into the command line for each step, in most cases: https://ircama.github.io/osm-carto-tutorials/git-workflow/ It can be helpful to look at some other finished PRs to see what changes were made. For example, #3754 added a text label for a linear feature, and #3443 added a line rendering for another feature. In this case you might also copy part of the code for |
I also attempted a step-by-step guide in a previous issue, which does not assume that you know anything about software development. #3782 (comment) |
I think it should be rendered, because in many cases it has already been rendered earlier :) For example: |
Expected behavior
Gates[edit:aeroway=parking_position
] were displayed at London Gatwick Airport but has disappeared.Show gates at LGW
Actual behavior
No
gates[edit:aeroway=parking_position
] showing at LGWLinks and screenshots illustrating the problem
Before:
After:
The text was updated successfully, but these errors were encountered: