Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amenity=parking rendered with two parking icons #3860

Closed
Prince-Kassad opened this issue Sep 1, 2019 · 7 comments · Fixed by #3874
Closed

amenity=parking rendered with two parking icons #3860

Prince-Kassad opened this issue Sep 1, 2019 · 7 comments · Fixed by #3874

Comments

@Prince-Kassad
Copy link

This also seems to be related to our switch to ST_PointOnSurface.

Example: https://www.openstreetmap.org/#map=18/51.94370/13.89742

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 1, 2019

Could anyone review all the changes from #3712 then in a systematic way, so we know what else can be broken?

@imagico
Copy link
Collaborator

imagico commented Sep 1, 2019

This is probably due to parkings being both in amenity-points and amenity-low-priority-poly - which has been the case before #3712 but did not show up because the placement was identical.

In other words: #3712 revealed a coding error that was present before.

amenity-low-priority and amenity-low-priority-poly need to be reviewed for duplicates with amenity-points (and possibly merged into one layer just like amenity-points).

@imagico imagico added the bug label Sep 1, 2019
@jragusa
Copy link
Contributor

jragusa commented Sep 1, 2019

This also affects other features such as buildings (I guess):

https://www.openstreetmap.org/way/452206220
bug1

https://www.openstreetmap.org/way/225166573
bug2

@imagico
Copy link
Collaborator

imagico commented Sep 1, 2019

@jragusa - this is already known, see #3781 (review). In principle there is nothing wrong with displaying both building name/POI and address but in this form this is of course confusing - see #3780 (comment)

@pnorman
Copy link
Collaborator

pnorman commented Sep 2, 2019

This also affects other features such as buildings (I guess):

This has been fixed with #3781

@Grillmannen
Copy link

Copied from issue 3866 referenced above:

Expected behavior

A parking lot should only be rendered with a P once on the centroid of the area

Actual behavior

In the example it's rendered twice with no visible data error

Links and screenshots illustrating the problem

https://www.openstreetmap.org/way/116351847
https://www.openstreetmap.org/#map=19/56.06334/12.70951
image

@kocio-pl kocio-pl mentioned this issue Sep 6, 2019
@jeisenbe jeisenbe added this to the Bugs and improvements milestone Sep 7, 2019
@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 7, 2019

Looks like we need to fix this one; lots of reports about the same problem.

Should we merge the amenity-low-priority-poly and amenity-low-priority layers at the same time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants