Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render an icon for shop = craft #2389

Closed
Alekzzander opened this issue Sep 30, 2016 · 7 comments
Closed

Render an icon for shop = craft #2389

Alekzzander opened this issue Sep 30, 2016 · 7 comments

Comments

@Alekzzander
Copy link

Hello!

Please render shop = craft, I mean, it's for shops that sell anything for art, and hope it'll be useful.

Thanks a lot.

@pnorman
Copy link
Collaborator

pnorman commented Oct 2, 2016

👎 to having its own icon with 2.4k uses and no special considerations. With that usage I would expected it to already be rendered as a generic shop.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 2, 2016

I'm not aware of any special considerations needed here and numbers are not a problem for me - the usage is already above 2k limit and rising fast, so reaching upper limit (like 5k) may happen in not so distant future:
taghistory 2

But I just don't know how should this icon look like. Any ideas?

@d1g
Copy link

d1g commented Oct 2, 2016

be rendered as a generic shop

It should be rendered as a generic shop first (I forgot issue where it was discussed last time)

We don't have time to pick/draw proper icons for every shop, but we may draw more shops (dots)

@aceman444
Copy link

I think the dot should be draws for any shop, where specific icon is not done. Not just for a selection of shops.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 2, 2016

@aceman444 Please fill new issue for this, since it's much broader than current issue.

@kocio-pl
Copy link
Collaborator

Looks like we already have an issue including this problem, so I wrote my comment.

@kocio-pl
Copy link
Collaborator

Resolved by #2415.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants