Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render label for historic=city_gate #152

Closed
dieterdreist opened this issue Sep 6, 2013 · 20 comments
Closed

render label for historic=city_gate #152

dieterdreist opened this issue Sep 6, 2013 · 20 comments
Labels
amenity-points enhancement new features Requests to render new features
Milestone

Comments

@dieterdreist
Copy link

City gates are mostly quite important features for orientation. Even if the citywalls or the city gate doesn't exist (or act as barriers) any more, they are usually still important for the local people as toponyms in way descriptions and the like. Please render historic=city_gate (not necessarily with an icon, but maybe like place=locality?).
http://taginfo.openstreetmap.org/tags/historic=city_gate

@matkoniecz
Copy link
Contributor

Can you give examples of city gates that should be rendered and tourism=attraction is not applicable?

example: http://www.openstreetmap.org/?mlat=50.06490&mlon=19.94135#map=19/50.06490/19.94135 - name gets rendered thanks to tourism=attraction.

@dieterdreist
Copy link
Author

2014/1/17 Bulwersator [email protected]

Can you give examples of city gates that should be rendered and
tourism=attraction is not applicable?

example:
http://www.openstreetmap.org/?mlat=50.06490&mlon=19.94135#map=19/50.06490/19.94135- name gets rendered thanks to tourism=attraction

adding tourism=attraction to what should be rendered is not the way I think
the map should work ;-)
All of them should IMHO be rendered, currently there are only 1000 of them
tagged in osm, but I guess if we render them their number will grow. Can
you give an example of a city gate that should not be rendered?
Here is a not so famous city gate, definitely not an attraction to the
generic visitor: http://www.openstreetmap.org/node/410779713

@CloCkWeRX
Copy link
Contributor

I dunno, from reading http://en.wikipedia.org/wiki/Porta_Metronia - historic=yes+description? would perhaps be better (assuming the name got rendered from that tagging)

@matkoniecz
Copy link
Contributor

@dieterdreist

"adding tourism=attraction to what should be rendered is not the way I think the map should work ;-)"

Yes, but adding tourism=attraction to tourism attractions is a good idea.

But I see that Porta Metronia maybe should not be tagged this way (what is quite funny as in my country any building that survived 1700 years would be instantly a major tourist attraction).

But I see even better reason to render tag in this case - existing wikipedia tag - what I reported as #317 (Render names for objects with wikipedia tag).

@dieterdreist
Copy link
Author

2014/1/18 CloCkWeRX [email protected]

I dunno, from reading http://en.wikipedia.org/wiki/Porta_Metronia -
historic=yes+description? would perhaps be better

why would it be better to change the tagging from something explicitly
describing well the nature (city gate) to something very generic and not
describing the object in a formal way?

After all, city gates are a very common and very important feature. Even if
the gate is long gone, these places still kept the name and are often very
important squares. Think of Potsdamer Platz or Mehringplatz in Berlin. It
lies in the nature of the feature that these are situated at crucial spots
in the urban topology (for centuries this have been the needle eyes where
all traffic had to pass in order to enter the city = all main streets
reflect this usually, and: these are also on the borderline between the
historic centre (inside the walls) and the more recent extension).

For everyone mapping in historical context this is (or should be) a main
feature, while for e.g. Australians or North Americans I agree it will
probably not have any significance (and won't occur, so they won't bother).

@matthijsmelissen matthijsmelissen added this to the New features milestone Aug 18, 2014
@matthijsmelissen matthijsmelissen changed the title render historic=city_gate (at least the name) Add rendering for historic=city_gate (at least the name) Sep 24, 2014
@matthijsmelissen matthijsmelissen changed the title Add rendering for historic=city_gate (at least the name) Add rendering for historic=city_gate Sep 24, 2014
@matkoniecz
Copy link
Contributor

see also #790 proposing doing this for barrier=gate

@dieterdreist
Copy link
Author

Yes, while gates should also have their name rendered (in the few cases where a name tag is present), it's worth to point out that historic=city_gate might also be applied to places without actual gates (still the name will typically be preserved, and in a lot of cases there will be traces, e.g. an opening in the city wall).

@matkoniecz matkoniecz changed the title Add rendering for historic=city_gate render label for historic=city_gate Sep 4, 2015
@kocio-pl
Copy link
Collaborator

Are we still interested in this? How should it be rendered then?

@dieterdreist
Copy link
Author

dieterdreist commented Sep 25, 2017 via email

@kocio-pl
Copy link
Collaborator

There is also icon in Osmic - one should test if and when (probably z18+/z19+) to render it:

https://github.com/gmgeo/osmic/blob/master/tourism/city-gate-14.svg

@matthijsmelissen
Copy link
Collaborator

This is one of the oldest issues, and relatively simple to implement. Is anyone willing to work on this?

@matthijsmelissen
Copy link
Collaborator

Is this something for @andrzej-r perhaps?

@jragusa
Copy link
Contributor

jragusa commented May 13, 2018

with the Osmic icon:

on building:
https://www.openstreetmap.org/way/317181351
city_gate_yvoire

on node:
https://www.openstreetmap.org/node/5092502909
city_gate_larochesurforon

@Tomasz-W
Copy link

What about man-made grey for this feature? It would match city walls then, which often city gates are connected with. I would also like to see test renderings with just a label to compare.

@jragusa
Copy link
Contributor

jragusa commented May 13, 2018

with man_made colour on same locations:
city_gate_yvoire_manmade

city_gate_larochesurforon_manmade

with label alone:
city_gate_yvoire_label

label is not displayed for the previous one (priority of street name ?). Adjacent gate:
https://www.openstreetmap.org/node/5092502910
city_gate_larochesurforon_label

I'm in favour for man_made colour which is also consistent with defensive towers

@dieterdreist
Copy link
Author

dieterdreist commented May 13, 2018 via email

@kocio-pl
Copy link
Collaborator

Man made black is consistent with all the towers and city walls, so I vote for this color too. @jragusa Could you prepare a PR?

@Tomasz-W
Copy link

Tomasz-W commented May 14, 2018

I have got 2 more ideas:

  • render also city gates tagged as relations (some of them are ruins with a few separated parts, example below)
  • render historic=city_gate + ruins=yes with lighter icon (like private parkings)

Example gates:
20161015_133518
20161015_133518

What do you think about it?

@kocio-pl
Copy link
Collaborator

Lighter icon might also work for castles/palaces/stately/manors etc. - but somebody has to test it. There's also a question how the historic=ruins should look like then (see #331).

Relations might not work because currently import using osm2pgsql does not move relation properties to their members.

@matkoniecz
Copy link
Contributor

matkoniecz commented May 16, 2018

render also city gates tagged as relations

these gates are tagged as multipolygons, right? In that case no special handling is needed (as long as labels for areas are displayed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amenity-points enhancement new features Requests to render new features
Projects
None yet
Development

No branches or pull requests

7 participants