Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render at least the first 4 ref tags no matter what when there are more than 4 refs on a highway #1051

Open
rickmastfan67 opened this issue Oct 12, 2014 · 8 comments

Comments

@rickmastfan67
Copy link

This is a spur off of #750.

https://www.openstreetmap.org/way/52035534

In Georgia with their love of signing state routes with US Highways, in the Folkston area, there is a section of highway that happens to have 7 different routes on it (US 1/23/301 & GA 4/15/23/121). Because of that, none of the routes ref tags get rendered since Mapnik currently will only render ways that have 4 or less refs on them.

What I'm suggesting is that Mapnik should render by default the first 4 ref tags of any way no matter what. In doing so, it would allow highway that are overloaded by their respective state with multiple highway designations to at least have some of them rendered at this time, till #596 can be done in the future.

So, in Folkston, even if just the first four of those routes can be rendered (the 3 US Highways + GA 4 since that's the order they are on the way) on the map, it would greatly improve this area.

@lest69
Copy link

lest69 commented Oct 15, 2014

If there are more than 4, what about rendering a small "+", "...", or something along those lines at the bottom of the shield to indicate there are more refs that have been truncated? Then someone who is interested will know that there are additional ones and can look at the data more closely.

@rickmastfan67
Copy link
Author

I guess the '+' or '...' could work. Just would need to add a space after the last ref.
Do you have any suggestions here @pnorman since you did do #750 that allowed us to have at least routes with 4 or less refs to be rendered (as long as they had 11 or less charters; see #1513 on this)?

@pnorman
Copy link
Collaborator

pnorman commented May 1, 2015

A small anything isn't an option, I don't see a way to change font size for that. An option would be to take the array, and if >4 lines members, cut it down to 3 and append a '…', '⋯' or '+'.

I'd rather tackle #1513 first.

@rickmastfan67
Copy link
Author

@pnorman, I'm just curious, but what idea do you think has the best chance of working that I suggested in #1513? Or do you have another idea to solve that ticket?

@pnorman
Copy link
Collaborator

pnorman commented May 14, 2015

No particular thoughts. My preference is based on how the query is constructed, and which one has a bigger impact.

I don't see getting to either issue myself. #596 is higher priority for shields for me, and it's not on my short term to-do list. Don't let this stop anyone from tackling either this or #1513, I just won't be doing it myself.

@talllguy
Copy link

I was wondering why parts of I-465 have no shields whatsoever. According to this issue, eight refs is not supported then?
2015-12-21 15_01_10-openstreetmap

@pnorman
Copy link
Collaborator

pnorman commented Dec 21, 2015

I was wondering why parts of I-465 have no shields whatsoever. According to this issue, eight refs is not supported then?

Yes.

Note: The way you linked has duplication in its ref and unsigned_ref tags

@talllguy
Copy link

@pnorman I edited the way to remove the duplication and that fixed it. I though routes render the shields, but I guess not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants