Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rendering of "label" member of relation #105

Closed
joakimfors opened this issue Aug 7, 2013 · 3 comments
Closed

Support rendering of "label" member of relation #105

joakimfors opened this issue Aug 7, 2013 · 3 comments

Comments

@joakimfors
Copy link

Administrative boundaries can have a "label" node member. It would be nice if the stylesheet rendered the name of the relation at the position of the label member node.

Related: #103 #104

@pnorman
Copy link
Collaborator

pnorman commented Aug 7, 2013

Is sufficient information in a standard osm2pgsql database to render this?

@gravitystorm
Copy link
Owner

It's entirely the wrong concept to put a "label" node in the database, and I'll not be using it for rendering.

The geodatabase is for geodata. Rendering decisions are made by the renderer. If the renderer isn't sufficiently advanced to place a label to your desire, then lets improve the renderer.

@Dimitar5555
Copy link

@gravitystorm Mappers work with what Carto offers them. You can't expect them to not put label (or admin_centre which is practically the same) elements when the relation's name is not rendered. After all they want to create some relationship between the area and the label/place center (which is usually not the same point as the centroid). Of course it would be fine to render names on the centroid if no label/admin center nodes are available.

If the name of the relation were rendered ignoring label nodes, the name would be in seemingly random places and mappers would not create relations for those objects. Also, I think it's important to note that mappers currently determine the label location by placing place=* nodes, so I don't see how having the same node with label role and no tags is a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants