feat: define database StatementPart, add identifierChain to TablesSuggestion, remove useless totos, migrate drop tests to typescript #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaShkaruba
force-pushed
the
85/drop_tests_refactoring
branch
from
d733d98 to
685a6c1
Compare
NikitaShkaruba
changed the title
NikitaShkaruba
commented
Nov 30, 2023
| { value: 'TABLE', weight: -1 }, | ||
| { value: 'VIEW', weight: -1 }, | ||
| ]; | ||
| expect(parseResult.suggestKeywords).toEqual(suggestions) |
There was a problem hiding this comment.
I've decided to move those tests closer to their definition. Even though it can be separated to alter_table, alter_view files. But the actual code that suggests it is alter_common, so it's better this way.
roberthovsepyan
approved these changes
Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #85