feat: move AggregateFunctionsSuggestion to a separate interface, refactor general parser create tests #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaShkaruba
changed the title
NikitaShkaruba
commented
Nov 29, 2023
| // - 'something [IF NOT EXITS]' | ||
| // - 'something IF [NOT EXISTS]' | ||
| // - 'something IF NOT [exists]' | ||
| // - 'something [IF NOT EXISTS] something2' |
There was a problem hiding this comment.
All the todos are fine, I'll fix them later
NikitaShkaruba
commented
Nov 29, 2023
| @@ -63,7 +63,7 @@ test('should suggest WHERE columns', () => { | |||
| }) | |||
|
|
|||
| test('should suggest WHERE columns when some column conditions already exist', () => { | |||
| const parseResult = parseGenericSqlWithoutCursor('DELETE FROM test_table WHERE test_column = 1 AND '); | |||
| const parseResult = parseGenericSql('DELETE FROM test_table WHERE test_column = 1 AND ', ''); | |||
There was a problem hiding this comment.
We have cursor, so I've decided to replace the function
| @@ -26,6 +26,7 @@ AlterTable | |||
| : AlterTableLeftSide PartitionSpec | |||
| ; | |||
|
|
|||
| // TODO: support AlterTableRightSide, PartitionSpec will not work for MySQL, PostgreSQL | |||
There was a problem hiding this comment.
We don't have ALTER TABLE table_name ADD column_name datatype; supported, sadly :(
There was a problem hiding this comment.
Yeah, noticed that..
| - A test that checks locations (can be merged with the one above) | ||
| - Don't use `foo` or `bar` custom names, always use `test_{object}`, e.g. `SELECT * FROM test_table`, not `SELECT * FROM hehe_haha`. If you need multiple names, use `_{number}` suffix, e.g. `SELECT test_field, test_field_2 FROM test_table;` | ||
| - Write all the static tokens in UPPER_CASE, and all the custom variables in lower_case, e.g. `SELECT test_field` | ||
| - Always test your statements on errors, and if there's an unexpected error, just add `TODO: fix unhandled error` error |
There was a problem hiding this comment.
Should I add something else, or is it complete?
There was a problem hiding this comment.
I think it's pretty good!
roberthovsepyan
requested changes
Nov 30, 2023
CODE_CONVENTIONS.md
Outdated
|
|
||
| - Each test should only test a granular added piece of logic, and shouldn't test functionality of other's. E.g. if you are using OptionalIfNotExists, you shouldn't test if you get suggestions when writing '', 'IF ', 'IF NOT', just test if `IF NOT EXISTS` is suggesting, and it's enough. | ||
| - Each test file should contain | ||
| - A test that on full statement for errors |
There was a problem hiding this comment.
typo: extra 'that'
| - A test that checks locations (can be merged with the one above) | ||
| - Don't use `foo` or `bar` custom names, always use `test_{object}`, e.g. `SELECT * FROM test_table`, not `SELECT * FROM hehe_haha`. If you need multiple names, use `_{number}` suffix, e.g. `SELECT test_field, test_field_2 FROM test_table;` | ||
| - Write all the static tokens in UPPER_CASE, and all the custom variables in lower_case, e.g. `SELECT test_field` | ||
| - Always test your statements on errors, and if there's an unexpected error, just add `TODO: fix unhandled error` error |
There was a problem hiding this comment.
I think it's pretty good!
| @@ -26,6 +26,7 @@ AlterTable | |||
| : AlterTableLeftSide PartitionSpec | |||
| ; | |||
|
|
|||
| // TODO: support AlterTableRightSide, PartitionSpec will not work for MySQL, PostgreSQL | |||
There was a problem hiding this comment.
Yeah, noticed that..
roberthovsepyan
approved these changes
Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #85