feat: add CommonSuggestion and JoinsSuggestion types, migrate postgresql tests to typescript #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 4, 2023 18:53
NikitaShkaruba
requested changes
Dec 5, 2023
| @@ -116,11 +118,16 @@ export interface FunctionsSuggestion { | |||
| types?: string[]; | |||
| } | |||
|
|
|||
| export interface FiltersSuggestion { | |||
| export interface CommonSuggestion { | |||
| prefix?: string; | |||
| tables: Table[]; | |||
| } | |||
There was a problem hiding this comment.
Common suggestion looks too general. Why not just create a FiltersSuggestion, and make GroupBysSuggestion, OrderBysSuggestion aliases?
Or else we need a better naming
NikitaShkaruba
approved these changes
Dec 5, 2023
roberthovsepyan
changed the title
This was referenced Dec 4, 2023
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #85