Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): show invalid state without passing error message #1554

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

dfilatov
Copy link
Contributor

Documentations says that error message is optional, but actually Select doesn't have error appearance (red border) without passing error message. This commit fixes that.

@dfilatov dfilatov requested a review from korvin89 as a code owner April 27, 2024 08:38
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

src/components/Select/Select.tsx Outdated Show resolved Hide resolved
@amje amje merged commit 882c9a9 into gravity-ui:main Apr 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants