Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ClipboardButton): add children and iconPosition #1837

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

kvestus
Copy link
Member

@kvestus kvestus commented Sep 5, 2024

No description provided.

@kvestus kvestus requested a review from Raubzeug as a code owner September 5, 2024 13:14
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@Raubzeug
Copy link
Contributor

Raubzeug commented Sep 5, 2024

Please add tests for your case.

@kvestus
Copy link
Member Author

kvestus commented Sep 5, 2024

Please add tests for your case.

Added test for my case and visual tests for all stories

@Raubzeug
Copy link
Contributor

Raubzeug commented Sep 5, 2024

Visual test will be added in #1777 , so no need in it in this PR

@kvestus kvestus force-pushed the feat-clipboard-button-children branch from 5b3146d to c538526 Compare September 5, 2024 14:51
@kvestus
Copy link
Member Author

kvestus commented Sep 5, 2024

@Raubzeug ready

@kvestus kvestus merged commit 4c3d070 into main Sep 5, 2024
6 checks passed
@kvestus kvestus deleted the feat-clipboard-button-children branch September 5, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants