fix(useFocusWithin): ignore blur event when window loses focus #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunaticenslaved
requested review from
amje,
ValeraS and
korvin89
as code owners
|
Preview is ready. |
|
Visual Tests Report is ready. |
lunaticenslaved
force-pushed
the
lunaticenslaved/fix-blur-on-firefox-window-unfocus
branch
2 times, most recently
from
5fdc882 to
d809e28
Compare
ValeraS
requested changes
Sep 5, 2024
Comment on lines
99
to
109
| if ( | ||
| document.activeElement === event.target && | ||
| (event.target instanceof HTMLButtonElement || | ||
| event.target instanceof HTMLInputElement || | ||
| event.target instanceof HTMLTextAreaElement || | ||
| event.target instanceof HTMLSelectElement) && | ||
| !event.target.disabled | ||
| ) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's remove this and add document.activeElement !== event.target && (...) to that check
uikit/src/hooks/useFocusWithin/useFocusWithin.ts
Lines 187 to 191 in 4c3d070
ValeraS
changed the title
korvin89
reviewed
Sep 5, 2024
lunaticenslaved
force-pushed
the
lunaticenslaved/fix-blur-on-firefox-window-unfocus
branch
from
d809e28 to
f723c13
Compare
Removed the block of code. It looks more obvious now I hope. |
ValeraS
approved these changes
Sep 8, 2024
ValeraS
deleted the
lunaticenslaved/fix-blur-on-firefox-window-unfocus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1737
Apparently when Firefox's window loses focus a blur event is fired.
It can be reproduced on Linux GNOME with
super+spaceto switch language. I do not know whether or not it works on KDE.It can be emulated on Mac with
control+spaceto open search bar.On Windows with switching language by
win+spaceit works fine.Maybe this solution can help.