Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NumberInput): add new component #1826

Merged
merged 37 commits into from
Nov 5, 2024
Merged

feat(NumberInput): add new component #1826

merged 37 commits into from
Nov 5, 2024

Conversation

DaryaLari
Copy link
Contributor

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@DaryaLari DaryaLari changed the title NumberInput feat(NumberInput): add new component Aug 28, 2024
@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@DaryaLari DaryaLari force-pushed the number-input branch 4 times, most recently from 68cd582 to f529fed Compare August 29, 2024 08:29
@DaryaLari DaryaLari marked this pull request as ready for review August 29, 2024 08:44
@DaryaLari DaryaLari marked this pull request as draft September 13, 2024 13:52
@DaryaLari DaryaLari marked this pull request as ready for review September 15, 2024 07:44
@DaryaLari
Copy link
Contributor Author

@korvin89 @amje
Hope that for now I have fixed all visible flaws... Could you check the changes, please?

@DaryaLari DaryaLari force-pushed the number-input branch 3 times, most recently from be77a52 to 29bfffd Compare September 19, 2024 16:34
@DaryaLari DaryaLari force-pushed the number-input branch 4 times, most recently from cd9c3bd to cc9165b Compare September 26, 2024 10:12
amje
amje requested changes Sep 26, 2024
View reviewed changes
src/components/lab/NumberInput/__stories__/NumberInput.stories.tsx Outdated Show resolved Hide resolved
src/components/lab/NumberInput/__tests__/NumberInput.visual.test.tsx Outdated Show resolved Hide resolved
src/components/lab/NumberInput/NumberInput.tsx Show resolved Hide resolved
src/components/controls/TextInput/TextInput.tsx Outdated Show resolved Hide resolved
src/components/lab/NumberInput/NumberInput.tsx Outdated Show resolved Hide resolved
src/components/lab/NumberInput/NumberInput.tsx Outdated Show resolved Hide resolved
src/components/lab/NumberInput/NumericArrows/NumericArrows.scss Outdated Show resolved Hide resolved
src/components/lab/NumberInput/NumericArrows/NumericArrows.scss Outdated Show resolved Hide resolved
src/components/lab/NumberInput/index.ts Outdated Show resolved Hide resolved
src/components/lab/NumberInput/utils.ts Outdated Show resolved Hide resolved
@DaryaLari DaryaLari force-pushed the number-input branch 3 times, most recently from b7b173b to faf3eaa Compare September 30, 2024 07:38
@DaryaLari DaryaLari requested a review from amje September 30, 2024 07:43
@DaryaLari
fix(NumberInput): fix after rebase
a729aa7
@DaryaLari
fix(NumberInput): arrows width
971c829
@DaryaLari
fix(NumberInput): inserting invalid string to the middle of number
baa6987
@DaryaLari
chore(NumberInput): change value type to number and add clamping valu…
ea8735d 
…es to divisible numbers
@DaryaLari
test: update snapshots
d00fa06
@DaryaLari
chore(NumberInput): move component to lab
81c6e48
@DaryaLari
fix(NumberInput): review fixes
0976903
@DaryaLari
docs(NumberInput): fix types in readme
f3588fb
@DaryaLari
docs(NumberInput): add description of behaviour props to readme
71d2970
@DaryaLari
fix(NumberInput): more review fixes
2310174
@DaryaLari
fix(NumberInput): duplicated arrows border style
43e99ce
@DaryaLari
fix(NumberInput): add e.preventDefault, rename showControls, remove f…
3d31b0b 
…orwardRef&comment in N-Arrows
@DaryaLari
fix(NumberInput): fix clapting to step divisibles
d925f52
@DaryaLari
fix(NumberInput): remove local step state
b8cc572
@DaryaLari
chore(NumberInput): handle home/end btns press
8fe03c0
@DaryaLari
test(NumberInput): add tests on HOME/END press
1b28334
@DaryaLari
fix(NumberInput): remove exporting default props from TextInput
510b110
@DaryaLari
fix(NumberInput): hide description&default columns from storybook con…
400b324 
…trols
@DaryaLari
feat(NumberInput): support uncontrolled usage type
3853ffc
@DaryaLari
chore(NumberInput): change input type in default story to uncontrolled
37fc976
@DaryaLari
chore(NumberInput): change all other stiries' inputs to uncontrolled
492b1a1
@DaryaLari
fix(NumberInput): rename css-vars & add aria-hidden attr to arrows
6118814
@DaryaLari
fix(NumberInput): fix formatting number on blur
463ef10
@DaryaLari
fix(NumberInput): set inputMode to decimal with allowDecimal param
b3496b0
@DaryaLari
fix(NumberInput): add rounding calculation result to step precision
aed0787
@DaryaLari DaryaLari merged commit 75be05e into main Nov 5, 2024
6 checks passed
@DaryaLari DaryaLari deleted the number-input branch November 5, 2024 10:18
@gravity-ui-bot gravity-ui-bot mentioned this pull request Nov 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValeraS ValeraS ValeraS approved these changes

@amje amje amje approved these changes

@korvin89 korvin89 Awaiting requested review from korvin89 korvin89 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DaryaLari @gravity-ui-bot @amje @ValeraS @korvin89