Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Pagination): add size prop #1759

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

spotikhanov
Copy link
Contributor

This change resolves #1653 by adding 'size' prop to Pagination component with backward compatibility.

@spotikhanov spotikhanov requested a review from jhoncool as a code owner August 17, 2024 13:46
@spotikhanov spotikhanov changed the title feat(Pagination): add size prop with backward feat(Pagination): add size prop Aug 17, 2024
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@jhoncool
Copy link
Contributor

@spotikhanov I think in the original issue user wanted to use another types of sizes. We can support s and xl cuz select, input and button support these sizes too.

@spotikhanov
Copy link
Contributor Author

@spotikhanov I think in the original issue user wanted to use another types of sizes. We can support s and xl cuz select, input and button support these sizes too.

Oh, if so, I can add 's' and 'xl' to the possible PaginationSize values and make sure everything works as expected

I've added tests just to make sure that adding 'size' will not cause pagination to change for users without this prop

@spotikhanov
Copy link
Contributor Author

@jhoncool added support for 's' and 'xl' variants. not really sure about the exact padding values in the following files:

  • PaginationEllipsis.scss
  • PaginationInput.scss
  • PaginationPage.scss
  • PaginationPageOf.scss

@jhoncool
Copy link
Contributor

@jhoncool added support for 's' and 'xl' variants. not really sure about the exact padding values in the following files:

  • PaginationEllipsis.scss
  • PaginationInput.scss
  • PaginationPage.scss
  • PaginationPageOf.scss

awesome 🤗

@spotikhanov spotikhanov force-pushed the pagination-size-prop branch from c25091e to d15e5f8 Compare August 22, 2024 13:38
@spotikhanov
Copy link
Contributor Author

@jhoncool Hi! Can we merge it? What's the workflow in Gravity UI, who can get a write access?

@jhoncool
Copy link
Contributor

jhoncool commented Aug 23, 2024

@jhoncool Hi! Can we merge it? What's the workflow in Gravity UI, who can get a write access?

I don't know 🤷‍♂️. I think you can do it.

@jhoncool jhoncool merged commit 12e5597 into gravity-ui:main Aug 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support size in Pagination
3 participants