-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Pagination): add size prop #1759
Conversation
Preview is ready. |
Visual Tests Report is ready. |
@spotikhanov I think in the original issue user wanted to use another types of sizes. We can support |
Oh, if so, I can add 's' and 'xl' to the possible PaginationSize values and make sure everything works as expected I've added tests just to make sure that adding 'size' will not cause pagination to change for users without this prop |
@jhoncool added support for 's' and 'xl' variants. not really sure about the exact padding values in the following files:
|
awesome 🤗 |
c25091e
to
d15e5f8
Compare
@jhoncool Hi! Can we merge it? What's the workflow in Gravity UI, who can get a write access? |
I don't know 🤷♂️. I think you can do it. |
This change resolves #1653 by adding 'size' prop to Pagination component with backward compatibility.