Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TextInput, TextArea): add readOnly property #1747

Merged
merged 5 commits into from
Aug 22, 2024
Merged

feat(TextInput, TextArea): add readOnly property #1747

merged 5 commits into from
Aug 22, 2024

Conversation

polikashina
Copy link
Contributor

@polikashina polikashina commented Aug 13, 2024 •
edited
Loading

Added readOnly prop to TextInput and TextArea controls
UXRFC-469

@polikashina polikashina requested a review from korvin89 as a code owner August 13, 2024 09:30
@polikashina polikashina changed the title Add explicit readonly prop to TextInput and TextArea feat: add explicit readonly prop to TextInput and TextArea Aug 13, 2024
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@polikashina polikashina self-assigned this Aug 13, 2024
korvin89
korvin89 requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@korvin89 korvin89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have decided that we should not changed background color

@polikashina polikashina force-pushed the feat/explicit-readonly-prop branch from 3a91e65 to 8cd9fc5 Compare August 16, 2024 07:35
@polikashina
Copy link
Contributor Author

We have decided that we should not changed background color

fixed

@polikashina polikashina requested a review from korvin89 August 19, 2024 13:58
@polikashina polikashina requested a review from korvin89 August 22, 2024 08:10
@korvin89 korvin89 changed the title feat: add explicit readonly prop to TextInput and TextArea feat(TextInput, TextArea): add readOnly property Aug 22, 2024
@polikashina polikashina merged commit 1c95f75 into main Aug 22, 2024
7 checks passed
@polikashina polikashina deleted the feat/explicit-readonly-prop branch August 22, 2024 09:42
@gravity-ui-bot gravity-ui-bot mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korvin89 korvin89 korvin89 approved these changes

@amje amje Awaiting requested review from amje amje is a code owner

@ValeraS ValeraS Awaiting requested review from ValeraS ValeraS is a code owner

Assignees

@polikashina polikashina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@polikashina @gravity-ui-bot @korvin89