feat(ListItemView): ability to pass custom react node as a content prop #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Visual Tests Report is ready. |
IsaevAlexandr
commented
Jul 30, 2024
| modToHeight[size][ | ||
| Number(Boolean(isListItemContentPropsGuard(content) ? content?.subtitle : false)) | ||
| ] | ||
| }px)`, |
There was a problem hiding this comment.
Here may be too match) but it's works and do exactly what i wont
minHeight: `var(--g-list-item-height, ${height ?? modToHeight[size][Number(Boolean(isListItemContentPropsGuard(content) ? content?.subtitle : false))]can set minHeight from props or override during css custom property in styles
IsaevAlexandr
commented
Jul 30, 2024
|
|
||
| {endSlot} | ||
| </Flex> | ||
| {isListItemContentPropsGuard(content) ? ( |
There was a problem hiding this comment.
here entry point in all changes of this pr
amje
approved these changes
Jul 31, 2024
DakEnviy
approved these changes
Jul 31, 2024
korvin89
approved these changes
Jul 31, 2024
IsaevAlexandr
changed the title
Raubzeug
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ent prop
What has been done:
contentprop inListItemView;Flexcomponent from root ofListItemViewcomponent. Flex uses inline styles what prevent class override approach ofListItemView;Now ListItemView look very close to previous approach of current
Listcomponent