Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): connect combobox to listbox #1665

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix(select): connect combobox to listbox #1665

merged 1 commit into from
Jun 19, 2024

Conversation

ValeraS
Copy link
Collaborator

@ValeraS ValeraS commented Jun 19, 2024

No description provided.

@ValeraS ValeraS requested a review from korvin89 as a code owner June 19, 2024 07:57
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@IsaevAlexandr
Copy link
Contributor

Hi, what is the motivation of that changes?
I'm asking because we have the same logic in TreeSelect component

@ValeraS
Copy link
Collaborator Author

ValeraS commented Jun 19, 2024

The combobox element should set aria-controls to a value that refers to the element that serves as the popup. The popup is an element that has role listbox, tree, grid, or dialog. In case of this component it should be a listbox.

@ValeraS ValeraS merged commit c61fe11 into main Jun 19, 2024
5 checks passed
@ValeraS ValeraS deleted the fix/select branch June 19, 2024 17:32
@gravity-ui-bot gravity-ui-bot mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korvin89 korvin89 korvin89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ValeraS @gravity-ui-bot @IsaevAlexandr @korvin89