feat(Portal): take in consideration parent theme #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Playwright Test Component is ready. |
korvin89
approved these changes
Apr 12, 2024
ValeraS
force-pushed
the
feat/portal-theme-provider
branch
from
94e7969 to
22980f3
Compare
amje
approved these changes
Apr 22, 2024
ValeraS
force-pushed
the
feat/portal-theme-provider
branch
from
22980f3 to
886c785
Compare
ValeraS
force-pushed
the
feat/portal-theme-provider
branch
from
886c785 to
380ffbe
Compare
IsaevAlexandr
requested changes
Apr 24, 2024
| // don't support runtime breakpoint redefinition. Breakpoints defined only one at LayoutTheme | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, []); | ||
| }, [breakpointsMap]); |
There was a problem hiding this comment.
if user pass layout theme object like
<ThemeProvider layout={{
config: {
breakpoints: {...}
}
}} >...</ThemeProvider>and App will have some state upper ThemeProvider it will cause this function to be constantly recalculated.
We need good reasons to be able to set breakpoints dynamically in runtime
There was a problem hiding this comment.
if config never changes, the user can move its creation outside the component. Otherwise, he can expect the changes to be taken into account.
| @@ -8,4 +8,5 @@ export interface ThemeContextProps { | |||
| theme: Theme; | |||
| themeValue: RealTheme; | |||
| direction: Direction; | |||
| scoped?: boolean; | |||
There was a problem hiding this comment.
may be some comment here?
why is this property needed?
IsaevAlexandr
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.