feat(Button): refactor to flex and center icons #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Playwright Test Component is ready. |
|
Preview is ready. |
teleginzhenya
commented
Mar 25, 2024
amje
requested changes
Mar 26, 2024
teleginzhenya
force-pushed
the
feature/UXRFC-435
branch
2 times, most recently
from
a23efb1 to
79ccb7a
Compare
teleginzhenya
force-pushed
the
feature/UXRFC-435
branch
from
e3507f6 to
b303f62
Compare
amje
requested changes
Mar 26, 2024
teleginzhenya
force-pushed
the
feature/UXRFC-435
branch
2 times, most recently
from
6cc9c7a to
b269fd5
Compare
teleginzhenya
force-pushed
the
feature/UXRFC-435
branch
2 times, most recently
from
b9990f6 to
a6a3221
Compare
amje
requested changes
Apr 3, 2024
src/components/Button/Button.scss
Outdated
Comment on lines
291
to
295
| order: 0; | ||
| } | ||
|
|
||
| &_side_end { | ||
| inset-inline-end: var(--_--icon-position); | ||
|
|
||
| & ~ #{$block}__text { | ||
| padding-inline-end: var(--_--icon-space); | ||
| } | ||
| order: 2; |
There was a problem hiding this comment.
Default value for order is 0, let's use-1 and 1 then?
teleginzhenya
force-pushed
the
feature/UXRFC-435
branch
from
a6a3221 to
4490b68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Button component was refactored to use modern flex. Position absolute and complex padding calculations was removed.