feat: add data, fallbackLang & lang options as constructor arguments #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
korvin89
changed the title
amje
reviewed
Jan 24, 2024
amje
requested changes
Jan 24, 2024
dgaponov
reviewed
Jan 24, 2024
dgaponov
previously approved these changes
Jan 25, 2024
ValeraS
requested changes
Jan 26, 2024
korvin89
force-pushed
the
add-default-lang
branch
from
81e4c64 to
cd62e12
Compare
amje
previously approved these changes
Jan 26, 2024
ValeraS
requested changes
Jan 26, 2024
dgaponov
previously approved these changes
Jan 26, 2024
ValeraS
approved these changes
Jan 26, 2024
dgaponov
approved these changes
Jan 26, 2024
amje
approved these changes
Jan 26, 2024
vladimirfilosof
pushed a commit
that referenced
this pull request
Mar 21, 2024
…40) * feat: add data, defaultLang & lang options as constructor arguments * refactor: rename defaultLang to fallbackLang * refactor: throw an error in case of languages absence * refactor: rework i18n method * refactor: change ErrorCode naming * fix: use object properties instead strings in mapErrorCodeToMessage switch cases * fix: review fixes * refactor: mark code property in mapErrorCodeToMessage as required * fix: do not throw an error in case of NoLanguageData * fix: remove fallbackLamg from getTranslationData method * fix: remove none actual test * fix: i18n method fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new arguments for I18N constructor:
data- keysets mapped datafallbackLang- language used as fallback in case there is no translation in the target languagelang- target language for the i18n instancePrevious PR - #39