Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve hints #209

Merged
merged 2 commits into from
Jul 16, 2024
Merged

feat: improve hints #209

merged 2 commits into from
Jul 16, 2024

Conversation

bratva
Copy link
Contributor

@bratva bratva commented Jul 13, 2024

Added display of hints for table headers
Added display of hints for vide mode

Screenshot 2024-07-13 at 12 37 51 Screenshot 2024-07-13 at 12 36 36 Screenshot 2024-07-13 at 12 36 54

@bratva
Copy link
Contributor Author

bratva commented Jul 13, 2024

However, I have concerns about this change. It will add the viewSpec.layoutDescription output to the view for all users, which may be unexpected for them.
upd: Added a special flag for this functionality

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

Add showLayoutDescription props
Add tests and update docs
@bratva bratva force-pushed the feat.description branch from 4920ea4 to 6e337ba Compare July 16, 2024 11:30
Add screenshots
@bratva
Copy link
Contributor Author

bratva commented Jul 16, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=ru.

@NasgulNexus NasgulNexus merged commit a69acfd into gravity-ui:main Jul 16, 2024
4 checks passed
@bratva bratva deleted the feat.description branch July 16, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants