feat(objectInline): support inline boolean fields #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Playwright Test Component is ready. |
NasgulNexus
requested changes
Feb 14, 2024
| @@ -30,6 +30,12 @@ test.describe('Checkbox', () => { | |||
|
|
|||
| await expectScreenshot(); | |||
| }); | |||
|
|
|||
| test('layout transparent', async ({mount, expectScreenshot}) => { | |||
There was a problem hiding this comment.
you need to take a screenshot, to do this you need to run the command npm run playwright:docker
| @@ -105,6 +105,7 @@ export const dynamicConfig: DynamicFormConfig = { | |||
| row: Row, | |||
| row_verbose: RowVerbose, | |||
| table_item: TableCell, | |||
| transparent: Transparent, | |||
There was a problem hiding this comment.
you also need to add a transparent layout for the dynamicViewConfig for boolean spec
There was a problem hiding this comment.
fixed.
@NasgulNexus plz, look at https://preview.gravity-ui.com/dynamic-forms/171/?path=/story/object-inline--inline
I've added checkbox. Looks like true|false on the View tab.
Perhaps it would be cool to set aliases in spec for the checkbox values? But I'm not sure that anyone needs it.
hozblok
force-pushed
the
inline-boolean
branch
from
bee6b33 to
42985a4
Compare
hozblok
changed the title
bocembocem
approved these changes
Feb 16, 2024
NasgulNexus
approved these changes
Feb 16, 2024
hozblok
force-pushed
the
inline-boolean
branch
from
42985a4 to
456e607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.