Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change locale from En to Ru using "configure" #166

Closed
js2me opened this issue Feb 13, 2024 · 6 comments
Closed

Unable to change locale from En to Ru using "configure" #166

js2me opened this issue Feb 13, 2024 · 6 comments
Assignees

Comments

@js2me
Copy link
Contributor

js2me commented Feb 13, 2024

Reproduce codesandbox:
https://codesandbox.io/p/sandbox/test-gravity-ui-dynamic-forms-hc28gn

@korvin89
Copy link

@bocembocem Hey! Could you triage this one?

@hozblok
Copy link
Contributor

hozblok commented Feb 15, 2024

@js2me
Hi,

I've just added

        fi: {
          type: SpecTypes.String,
          viewSpec: {
            type: "file_input",
            layout: "row",
            layoutTitle: "File Input",
          },
        },

to your spec, and language switches correctly.

Screen.Recording.2024-02-15.at.14.23.09.mov

Could you please describe the steps to reproduce the problem?

@js2me
Copy link
Contributor Author

js2me commented Feb 15, 2024

@hozblok Yes, sorry, the problem is includes in error message after form validation ("Empty field" should be localized ???)

test-gravity-ui-dynamic-forms.-.CodeSandbox.-.Google.Chrome.2024-02-15.16-32-30.1.mp4

@hozblok
Copy link
Contributor

hozblok commented Feb 15, 2024

@hozblok Yes, sorry, the problem is includes in error message after form validation ("Empty field" should be localized ???)

test-gravity-ui-dynamic-forms.-.CodeSandbox.-.Google.Chrome.2024-02-15.16-32-30.1.mp4

@js2me Yes, it should be localized. I will take a look at it.

@hozblok
Copy link
Contributor

hozblok commented Feb 16, 2024

@js2me Hi,

It was fixed,
Please, try it here: https://stackblitz.com/edit/vitejs-vite-c2tzjx?file=src%2FApp.tsx

Is this what you expected?

@js2me
Copy link
Contributor Author

js2me commented Feb 17, 2024

Yes

@js2me Hi,

It was fixed, Please, try it here: https://stackblitz.com/edit/vitejs-vite-c2tzjx?file=src%2FApp.tsx

Is this what you expected?

Yes, big thanks <3

@js2me js2me closed this as completed Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants