Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add spec correctness check for view controller #127

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix: add spec correctness check for view controller #127

merged 1 commit into from
Oct 17, 2023

Conversation

bocembocem
Copy link
Collaborator

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

NasgulNexus
NasgulNexus reviewed Oct 12, 2023
View reviewed changes
src/lib/core/components/View/ViewController.tsx Outdated
}

return null;
return <>{render}</>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<React.Fragment>{render}</React.Fragment>;

@bocembocem bocembocem merged commit a1f3601 into main Oct 17, 2023
3 checks passed
@bocembocem bocembocem deleted the view-controller-fix branch October 17, 2023 09:18
@gravity-ui-bot gravity-ui-bot mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NasgulNexus NasgulNexus NasgulNexus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bocembocem @gravity-ui-bot @NasgulNexus