Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: parse well known date strings #81

Merged
merged 2 commits into from
Nov 26, 2024
Merged

feat: parse well known date strings #81

merged 2 commits into from
Nov 26, 2024

Conversation

ValeraS
Copy link
Collaborator

@ValeraS ValeraS commented Nov 1, 2024

No description provided.

@ValeraS ValeraS marked this pull request as ready for review November 1, 2024 14:52
@ValeraS ValeraS requested review from amje and korvin89 as code owners November 1, 2024 14:52
arteria32
arteria32 reviewed Nov 15, 2024
View reviewed changes
Copy link

@arteria32 arteria32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, thank for you PR!.
Cool changes!
I have leaved some comments, but I open to dialog and we can discuss your solutions.

src/locale/english.ts Show resolved Hide resolved
src/dateTime/parse.ts Outdated Show resolved Hide resolved
src/dateTime/parse.ts Outdated Show resolved Hide resolved
src/dateTime/regexParse.ts Show resolved Hide resolved
src/dateTime/regexParse.ts Show resolved Hide resolved
src/dateTime/regexParse.ts Outdated Show resolved Hide resolved
src/dateTime/regexParse.ts Show resolved Hide resolved
src/dateTime/regexParse.ts Show resolved Hide resolved
@ValeraS ValeraS merged commit 3e1b974 into main Nov 26, 2024
2 checks passed
@ValeraS ValeraS deleted the feat/parse-date-rfc branch November 26, 2024 10:57
@gravity-ui-bot gravity-ui-bot mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arteria32 arteria32 arteria32 left review comments

@korvin89 korvin89 korvin89 approved these changes

@amje amje Awaiting requested review from amje amje is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValeraS @korvin89 @arteria32