Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(D3 plugin): add second Y axis support #480

Merged
merged 8 commits into from
May 17, 2024
Merged

feat(D3 plugin): add second Y axis support #480

merged 8 commits into from
May 17, 2024

Conversation

kuzmadom
Copy link
Contributor

@kuzmadom kuzmadom commented May 16, 2024 •
edited
Loading

closes #332

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@kuzmadom kuzmadom removed the d3: line label May 16, 2024
@kuzmadom kuzmadom marked this pull request as ready for review May 16, 2024 14:20
@kuzmadom kuzmadom requested a review from korvin89 May 16, 2024 14:24
korvin89
korvin89 reviewed May 16, 2024
View reviewed changes
Copy link
Collaborator

@korvin89 korvin89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add validation for yAxis property

.eslintignore Outdated Show resolved Hide resolved
src/plugins/d3/renderer/components/AxisY.tsx Outdated Show resolved Hide resolved
src/plugins/d3/renderer/hooks/useChartOptions/y-axis.ts Outdated Show resolved Hide resolved
src/types/widget-data/area.ts Show resolved Hide resolved
src/plugins/d3/renderer/hooks/useShapes/area/prepare-data.ts Show resolved Hide resolved
@kuzmadom kuzmadom merged commit 7cadd8e into main May 17, 2024
3 checks passed
@kuzmadom kuzmadom deleted the d3-second-y-axis branch May 17, 2024 08:43
@gravity-ui-bot gravity-ui-bot mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korvin89 korvin89 korvin89 approved these changes

Assignees
No one assigned
Labels
d3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[D3 plugin]: add support for multiple Y axes
3 participants
@kuzmadom @gravity-ui-bot @korvin89