Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an RFD spell check step to the lint workflow #50214

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

rosstimothy
Copy link
Contributor

@rosstimothy rosstimothy commented Dec 13, 2024

In order for the action to pass various RFDs were updated to fix misspellings, and the dictionary was expanded.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-50214.d3pp5qlev8mo18.amplifyapp.com

@rosstimothy rosstimothy force-pushed the tross/lint_rfd branch 5 times, most recently from a7465e3 to 11aa581 Compare December 13, 2024 20:35
@rosstimothy rosstimothy changed the title WIP Add an RFD spell check step to the lint workflow Dec 13, 2024
@rosstimothy rosstimothy marked this pull request as ready for review December 13, 2024 20:38
@github-actions github-actions bot added rfd Request for Discussion size/lg labels Dec 13, 2024
@rosstimothy rosstimothy added the no-changelog Indicates that a PR does not require a changelog entry label Dec 13, 2024
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
.github/workflows/lint.yaml Show resolved Hide resolved
.github/workflows/lint.yaml Show resolved Hide resolved
uses: actions/checkout@v4

- name: Install JS dependencies
run: pnpm install --frozen-lockfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all deps or just cspell?

rfd/cspell.json Show resolved Hide resolved
Copy link
Contributor

@fheinecke fheinecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed something minor on first pass. Eitehr way, LGTM

.github/workflows/lint.yaml Outdated Show resolved Hide resolved
@rosstimothy rosstimothy force-pushed the tross/lint_rfd branch 2 times, most recently from f474b4f to c7a3a80 Compare December 13, 2024 21:22
In order for the action to pass various RFDs were updated to fix
misspellings, and the dictionary was expanded.
@rosstimothy rosstimothy added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit 0bc64eb Dec 13, 2024
44 checks passed
@rosstimothy rosstimothy deleted the tross/lint_rfd branch December 13, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry rfd Request for Discussion size/lg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants