Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Enroll New Integration button on missing permissions #50173

Merged
merged 1 commit into from
Dec 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,22 @@ import { Box, Text, Flex } from 'design';

export const MissingPermissionsTooltip = ({
missingPermissions,
requiresAll = true,
}: {
missingPermissions: string[];
requiresAll?: boolean;
}) => {
return (
<Box>
<Text mb={1}>You do not have all of the required permissions.</Text>
<Box mb={1}>
<Text bold>Missing permissions:</Text>
{requiresAll ? (
<Text bold>Missing permissions:</Text>
) : (
<Text bold>
You must have at least one of these role permissions:
</Text>
)}
<Flex gap={2}>
{missingPermissions.map(perm => (
<Text key={perm}>{perm}</Text>
Expand Down
10 changes: 8 additions & 2 deletions web/packages/teleport/src/Integrations/Integrations.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ export function Integrations() {
const { attempt, run } = useAttempt('processing');

const ctx = useTeleport();
const canCreateIntegrations = ctx.storeUser.getIntegrationsAccess().create;

useEffect(() => {
// TODO(lisa): handle paginating as a follow up polish.
Expand Down Expand Up @@ -82,7 +81,14 @@ export function Integrations() {
<FeatureBox>
<FeatureHeader>
<FeatureHeaderTitle>Integrations</FeatureHeaderTitle>
<IntegrationsAddButton canCreate={canCreateIntegrations} />
<IntegrationsAddButton
requiredPermissions={[
{
value: ctx.storeUser.getIntegrationsAccess().create,
label: 'integration.create',
},
]}
/>
</FeatureHeader>
{attempt.status === 'failed' && <Alert children={attempt.statusText} />}
{attempt.status === 'processing' && (
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
/**
* Teleport
* Copyright (C) 2024 Gravitational, Inc.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

import { MemoryRouter } from 'react-router';
import { render, screen } from 'design/utils/testing';

import { IntegrationsAddButton } from './IntegrationsAddButton';

test('is disables if all permissions are missing', async () => {
render(
<MemoryRouter>
<IntegrationsAddButton
requiredPermissions={[
{ value: false, label: 'permissions.1' },
{ value: false, label: 'permissions.2' },
]}
/>
</MemoryRouter>
);

expect(
screen.getByTitle('You do not have access to add new integrations')
).toBeInTheDocument();
});

test('is enabled if at least one permission is true', async () => {
render(
<MemoryRouter>
<IntegrationsAddButton
requiredPermissions={[
{ value: false, label: 'permissions.1' },
{ value: true, label: 'permissions.2' },
]}
/>
</MemoryRouter>
);

expect(screen.getByText('Enroll New Integration')).toBeEnabled();
});
48 changes: 35 additions & 13 deletions web/packages/teleport/src/Integrations/IntegrationsAddButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,26 +19,48 @@
import React from 'react';
import { Link } from 'react-router-dom';
import { Button } from 'design';
import { HoverTooltip } from 'design/Tooltip';
import { MissingPermissionsTooltip } from 'shared/components/MissingPermissionsTooltip';

import cfg from 'teleport/config';

export function IntegrationsAddButton({
canCreate = false,
requiredPermissions,
}: {
canCreate: boolean;
requiredPermissions: { value: boolean; label: string }[];
}) {
const canCreateIntegrations = requiredPermissions.some(v => v.value);
const missingPermissions = requiredPermissions
.filter(perm => !perm.value)
.map(perm => perm.label);

return (
<Button
intent="primary"
fill="border"
as={Link}
ml="auto"
width="240px"
disabled={!canCreate}
to={cfg.getIntegrationEnrollRoute()}
title={canCreate ? '' : 'You do not have access to add new integrations'}
<HoverTooltip
tipContent={
canCreateIntegrations ? null : (
<MissingPermissionsTooltip
requiresAll={false}
missingPermissions={missingPermissions}
/>
)
}
>
Enroll New Integration
</Button>
<Button
intent="primary"
fill="border"
as={Link}
ml="auto"
width="240px"
disabled={!canCreateIntegrations}
to={cfg.getIntegrationEnrollRoute()}
title={
canCreateIntegrations
? ''
: 'You do not have access to add new integrations'
}
>
Enroll New Integration
</Button>
</HoverTooltip>
);
}
14 changes: 12 additions & 2 deletions web/packages/teleport/src/features.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,12 @@ export class FeatureBots implements TeleportFeature {
component: Bots,
};

hasAccess() {
hasAccess(flags: FeatureFlags) {
// if feature hiding is enabled, only show
// if the user has access
if (cfg.hideInaccessibleFeatures) {
return flags.listBots;
}
return true;
}

Expand Down Expand Up @@ -435,7 +440,12 @@ export class FeatureIntegrations implements TeleportFeature {
section = ManagementSection.Access;

hasAccess(flags: FeatureFlags) {
return flags.integrations;
// if feature hiding is enabled, only show
// if the user has access
if (cfg.hideInaccessibleFeatures) {
return flags.integrations;
}
return true;
}

route = {
Expand Down
Loading