-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Enroll New Integration button on missing permissions #50173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avatus
added
no-changelog
Indicates that a PR does not require a changelog entry
backport-required
backport/branch/v16
backport/branch/v17
labels
Dec 12, 2024
ryanclark
approved these changes
Dec 12, 2024
avatus
force-pushed
the
avatus/integrationperms
branch
from
December 12, 2024 22:02
3eaedeb
to
9b508d8
Compare
flyinghermit
approved these changes
Dec 13, 2024
This will disable to Enroll New Integration button if the user does not have the required permissions. It also updates the MissingPermissionsTooltip to handle cases where a list of permissions represents "one of these" required permissions scenarios instead of "all of these".
avatus
force-pushed
the
avatus/integrationperms
branch
from
December 13, 2024 02:35
9b508d8
to
62ba5cf
Compare
I hijacked a small part of this PR to include the feature hiding change for |
avatus
added a commit
that referenced
this pull request
Dec 13, 2024
This will disable to Enroll New Integration button if the user does not have the required permissions. It also updates the MissingPermissionsTooltip to handle cases where a list of permissions represents "one of these" required permissions scenarios instead of "all of these".
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
…#50220) This will disable to Enroll New Integration button if the user does not have the required permissions. It also updates the MissingPermissionsTooltip to handle cases where a list of permissions represents "one of these" required permissions scenarios instead of "all of these".
avatus
added a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v16
backport/branch/v17
backport-required
no-changelog
Indicates that a PR does not require a changelog entry
size/sm
ui
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will disable to Enroll New Integration button if the user does not have the required permissions.
It also updates the MissingPermissionsTooltip to handle cases where a list of permissions represents "one of these" required permissions scenarios instead of "all of these".
Contributes to https://github.com/gravitational/teleport.e/issues/4978
e counterpart: https://github.com/gravitational/teleport.e/pull/5690