Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Enroll New Integration button on missing permissions #50173

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

avatus
Copy link
Contributor

@avatus avatus commented Dec 12, 2024

This will disable to Enroll New Integration button if the user does not have the required permissions.

It also updates the MissingPermissionsTooltip to handle cases where a list of permissions represents "one of these" required permissions scenarios instead of "all of these".

Screenshot 2024-12-12 at 3 51 15 PM
Screenshot 2024-12-12 at 3 45 23 PM

Contributes to https://github.com/gravitational/teleport.e/issues/4978

e counterpart: https://github.com/gravitational/teleport.e/pull/5690

@avatus avatus force-pushed the avatus/integrationperms branch from 3eaedeb to 9b508d8 Compare December 12, 2024 22:02
@avatus avatus added this pull request to the merge queue Dec 13, 2024
@avatus avatus removed this pull request from the merge queue due to a manual request Dec 13, 2024
This will disable to Enroll New Integration button if the user does not
have the required permissions.

It also updates the MissingPermissionsTooltip to handle cases where a
list of permissions represents "one of these" required permissions
scenarios instead of "all of these".
@avatus avatus force-pushed the avatus/integrationperms branch from 9b508d8 to 62ba5cf Compare December 13, 2024 02:35
@avatus avatus enabled auto-merge December 13, 2024 02:35
@avatus avatus added this pull request to the merge queue Dec 13, 2024
@avatus
Copy link
Contributor Author

avatus commented Dec 13, 2024

I hijacked a small part of this PR to include the feature hiding change for bots feature as well

Merged via the queue into master with commit 1bbde4b Dec 13, 2024
40 checks passed
@avatus avatus deleted the avatus/integrationperms branch December 13, 2024 02:51
@public-teleport-github-review-bot

@avatus See the table below for backport results.

Branch Result
branch/v16 Failed
branch/v17 Failed

avatus added a commit that referenced this pull request Dec 13, 2024
This will disable to Enroll New Integration button if the user does not
have the required permissions.

It also updates the MissingPermissionsTooltip to handle cases where a
list of permissions represents "one of these" required permissions
scenarios instead of "all of these".
github-merge-queue bot pushed a commit that referenced this pull request Dec 13, 2024
…#50220)

This will disable to Enroll New Integration button if the user does not
have the required permissions.

It also updates the MissingPermissionsTooltip to handle cases where a
list of permissions represents "one of these" required permissions
scenarios instead of "all of these".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants