tsh: remove noisy debug log #50037
Merged
tsh: remove noisy debug log #50037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
zmb3
added
the
no-changelog
GavinFrazar
approved these changes
Dec 10, 2024
Teleport TLS certificate valid until "2024-12-11 04:35:25 +0000 UTC" This log line is not super helpful and adds a lot of noise to tsh debug logs because it is repeated many times. We don't need it, because: - it doesn't tell you _what_ certificate is valid - encountering a valid certificate is expected behavior and not something that we expect to help when debugging an issue
zmb3
force-pushed
the
zmb3/tsh-debug-noise
branch
from
c00f0b9 to
c4d2d7a
Compare
rosstimothy
approved these changes
Dec 11, 2024
public-teleport-github-review-bot
bot
removed the request for review
from probakowski
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This log line is not super helpful and adds a lot of noise to tsh debug logs because it is repeated many times.
We don't need it, because: