fix: remove support for configuration of insecure TLS cipher suites #49665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uites changelog: Removed support for manual configuration of insecure TLS cipher suites.
zmb3
approved these changes
Dec 2, 2024
rosstimothy
approved these changes
Dec 3, 2024
public-teleport-github-review-bot
bot
removed request for
flyinghermit and
strideynet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These suites are considered insecure by crypto/tls. We don't ever use them by default, but we currently allow Teleport admins to manually configure them in their configuration file. I propose we remove support for even manually configuring these. Since this is a breaking change I will not backport to any release branches.
Fixes https://github.com/gravitational/teleport/security/code-scanning/1004
changelog: Removed support for manual configuration of insecure TLS cipher suites.