[v16] Add ownership tags to AWS OIDC EKS Enrollment #45725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ownership tags to AWS OIDC EKS Enrollment This PR adds the ownership tags to the temporary EKS Access Entry created during the EKS Enrollment. There might happen that the user already completed the set up once, and so they won't be asked to run the configuration script (using oneoff + cloudshell) again. If there's a access denied, the Access Entry is created without the tags. With or without the tags, the Access Entry is removed after the enrollment process. * log message asking users to add eks:TagResource action * fix indentation in docs * fix new tests
marcoandredinis
had a problem deploying
to
vercel
GitHub Actions
Failure
github-actions
bot
added
backport
discovery
documentation
rfd
greedy52
approved these changes
Aug 23, 2024
zmb3
changed the title
zmb3
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #44736 to v16
changelog: For new EKS Cluster auto-enroll configurations, the temporary Access Entry is tagged with
teleport.dev/namespaced tags. For existing set ups, please add theeks:TagResourceaction to the Integration IAM Role to get the same behavior.