Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new tctl bots update command #36496

Merged
merged 18 commits into from
Jan 22, 2024
Merged

Add new tctl bots update command #36496

merged 18 commits into from
Jan 22, 2024

Conversation

timothyb89
Copy link
Contributor

This adds a new command to update roles and logins for existing bots, with flags to both set and append as desired.

changelog: Add new tctl bots update command to update bot roles and logins

Closes #34262

@timothyb89
Add new tctl bots update command
8de769b 
This adds a new command to update roles and logins for existing bots,
with flags to both set and append as desired.

changelog: Add new `tctl bots update` command to update bot roles and logins
@timothyb89
Pluralize "add-" flags for consistency
8566578
@timothyb89
Merge remote-tracking branch 'origin/master' into timothyb89/tctl-upd…
c07308e 
…ate-bot
@timothyb89
Add docs for tctl bots update
91ca4db 
Also merges in some other misc docs changes for `tctl bots ...`
@timothyb89 timothyb89 marked this pull request as ready for review January 10, 2024 23:49
@github-actions github-actions bot requested a review from zmb3 January 10, 2024 23:50
@github-actions github-actions bot added size/md tctl tctl - Teleport admin tool labels Jan 10, 2024
@timothyb89 timothyb89 requested a review from strideynet January 10, 2024 23:50
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-r3txznhhz-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-oljes2xje-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-85fdrdbgs-goteleport.vercel.app/docs/ver/preview

@strideynet
Copy link
Contributor

Should we be using the new UpdateBot RPC for this instead ? Or is this so we can backport this further?

ptgott
ptgott approved these changes Jan 11, 2024
View reviewed changes
docs/pages/reference/cli/tctl.mdx Outdated Show resolved Hide resolved
docs/pages/reference/cli/tctl.mdx Outdated Show resolved Hide resolved
docs/pages/reference/cli/tctl.mdx Outdated Show resolved Hide resolved
@timothyb89 @ptgott
Apply suggestions from code review
b6e9078 
Co-authored-by: Paul Gottschling <[email protected]>
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-1g7f28sxi-goteleport.vercel.app/docs/ver/preview

@timothyb89
Use the bot service's UpdateBot() RPC instead of modifying directly
257a2eb 
This switches to use the new `UpdateBot()` RPC instead of modifying
the bot user and role directly. Also, tweaks CLI messaging to be a
bit less chatty.
@timothyb89
Copy link
Contributor Author

Should we be using the new UpdateBot RPC for this instead ? Or is this so we can backport this further?

Ah, good call, truthfully I forgot we had an explicit update RPC now 😅.

Anyway, I've updated it to use the correct RPC.

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-8b9m8bos0-goteleport.vercel.app/docs/ver/preview

rosstimothy
rosstimothy reviewed Jan 17, 2024
View reviewed changes
lib/utils/set/set.go Outdated Show resolved Hide resolved
lib/utils/set/set.go Outdated Show resolved Hide resolved
codingllama
codingllama reviewed Jan 17, 2024
View reviewed changes
lib/utils/set/set.go Outdated Show resolved Hide resolved
@timothyb89
Remove set abstraction
9da8659 
Removes the Set package and unrolls all related function calls in
bots_command.
@timothyb89
Merge remote-tracking branch 'origin/master' into timothyb89/tctl-upd…
3de5d65 
…ate-bot
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-8klnr2zss-goteleport.vercel.app/docs/ver/preview

jimbishopp
jimbishopp reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@jimbishopp jimbishopp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Tim! A couple of thoughts on this. Sorry for the last minute quarterbacking. :)

tool/tctl/common/bots_command.go Outdated Show resolved Hide resolved
@timothyb89
Add unit tests for updateBotLogins() and updateBotRoles()
f6ea1b3 
This also makes a minimal API wrapper interface for mocking.
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-4gfq6ays6-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-au6zkinpw-goteleport.vercel.app/docs/ver/preview

zmb3
zmb3 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one docs nit.

docs/pages/reference/cli/tctl.mdx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-dsmwwjpgh-goteleport.vercel.app/docs/ver/preview

@timothyb89 timothyb89 added this pull request to the merge queue Jan 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@timothyb89 timothyb89 added this pull request to the merge queue Jan 22, 2024
Merged via the queue into master with commit 8532972 Jan 22, 2024
40 checks passed
@timothyb89 timothyb89 deleted the timothyb89/tctl-update-bot branch January 22, 2024 22:45
@public-teleport-github-review-bot
Copy link

@timothyb89 See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Create PR

@timothyb89 timothyb89 mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosstimothy rosstimothy rosstimothy left review comments

@codingllama codingllama codingllama left review comments

@jimbishopp jimbishopp jimbishopp left review comments

@ptgott ptgott ptgott approved these changes

@fheinecke fheinecke fheinecke approved these changes

@hugoShaka hugoShaka hugoShaka approved these changes

@strideynet strideynet strideynet approved these changes

@zmb3 zmb3 zmb3 approved these changes

Assignees
No one assigned
Labels
backport/branch/v14 backport/branch/v15 documentation size/md tctl tctl - Teleport admin tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Machine ID: tctl support for modifying Bots roleset
9 participants
@timothyb89 @strideynet @jimbishopp @zmb3 @codingllama @hugoShaka @fheinecke @ptgott @rosstimothy