Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS Discover enrollment can't download correct chart version for non-standard releases #42335

Closed
AntonAM opened this issue Jun 3, 2024 · 2 comments · Fixed by #42345
Closed
Assignees
Labels
bug discover Issues related to Teleport Discover kubernetes-access test-plan-problem Issues which have been surfaced by running the manual release test plan

Comments

@AntonAM
Copy link
Contributor

AntonAM commented Jun 3, 2024

Because of our recent change in artifacts release strategy (non standard releases like -alpha, -dev, -rc etc go to another repo) when EKS enrollment tries to download chart for a non standard release version it can't find it in the main repo.

@AntonAM AntonAM added bug test-plan-problem Issues which have been surfaced by running the manual release test plan kubernetes-access discover Issues related to Teleport Discover labels Jun 3, 2024
@AntonAM AntonAM self-assigned this Jun 3, 2024
@ravicious
Copy link
Member

ravicious commented Jun 4, 2024

We have a similarish issue with Connect My Computer in Connect (#42348, cc @gzdunek). It checks what version the Electron app is at and then it tries to download the teleport binary from cdn.teleport.dev. But since alpha releases are now on cdn.cloud.gravitational.io, Connect My Computer doesn't work with the alpha.

I'm curious how you'll decide to approach this for EKS Discover. One solution would be to check the version string and decide based on that, but this would require some kind of contract from the release team. E.g., anything other than final releases goes to cdn.teleport.dev, everything else including alphas, betas and rcs goes to cdn.cloud.gravitational.io.

In the case of Connect My Computer, we could always try cdn.teleport.dev first and then cdn.cloud.gravitational.io if we get 404.

@AntonAM
Copy link
Contributor Author

AntonAM commented Jun 4, 2024

@ravicious We went with the "all pre release tags routed to the staging repo" approach. Fred confirmed that all pre releases except for cloud-only ones go to staging, but for EKS Discover on cloud we take version from the cloud/stable channel anyway. There also was a bit of a discussion here: https://gravitational.slack.com/archives/C03LK5ZV4AE/p1717513866311889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug discover Issues related to Teleport Discover kubernetes-access test-plan-problem Issues which have been surfaced by running the manual release test plan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants