Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX for moderated sessions #10818

Closed
benarent opened this issue Mar 3, 2022 · 3 comments · Fixed by #10991
Closed

Improve UX for moderated sessions #10818

benarent opened this issue Mar 3, 2022 · 3 comments · Fixed by #10991

Comments

@benarent
Copy link
Contributor

benarent commented Mar 3, 2022

Description

While testing moderated sessions, I found the lack of feedback a tough UX. Sessions the require a use to join, look like they just hang.

What happened:

Teleport > Creating session with ID: 544c73f5-a56d-4160-8f70-4779e3ec433e...

Teleport > User ben-test joined the session.

What you expected to happen:
We should provide context for which roles need to join.

Creating session with uuid <example-uuid>...
This session requires moderator. Waiting for others to join:
- role: auditor-role x1
@xacrimon
Copy link
Contributor

xacrimon commented Mar 4, 2022

Hi, due to the RBAC model of moderated sessions, there's many possible combinations that could exist that would allow a session to start. Would broadcasting Teleport > Waiting for required participants... be sufficient or would we be better of making a list of sections, each containing a list of at least one item that must be satisfied. This feels very clunky to do in the terminal however and eats a lot of space.

For context, the RBAC model allows a session to start if at least one require policy is satisfied for every role that declares at least one such policy.

Such ux could look something like this:

Teleport > This session requires additional participants. Waiting for others to join:
  role1:
    - 2x auditor-role
    - 1x developer-role
  role 2:
    - 1x senior-developer-role 

@benarent
Copy link
Contributor Author

benarent commented Mar 4, 2022

Would broadcasting Teleport > Waiting for required participants... be sufficient

I think this will be a good place to start. But we might want to double check with @xinding33 . Could we also remove the space between the messages?

@xacrimon
Copy link
Contributor

xacrimon commented Mar 4, 2022

Yep, we can, as part of #10725 I'm making some changes to the UX, this proposal is also pending review from Xin. Let's move this discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants