Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

Split disk watermark check into low and high #1662

Closed
5 tasks done
r0mant opened this issue Jun 5, 2020 · 1 comment
Closed
5 tasks done

Split disk watermark check into low and high #1662

r0mant opened this issue Jun 5, 2020 · 1 comment
Assignees
Labels
port/5.5 Requires port to version/5.5.x port/6.1 Requires port to version/6.1.x port/7.0 Requires port to version/7.0.x priority/1 Medium priority

Comments

@r0mant
Copy link
Contributor

r0mant commented Jun 5, 2020

The current satellite high watermark for disk check is hardcoded at 80%. This causes issues for some customers during upgrades from older versions (e.g. 5.0) because this check triggers during an upgrade. Moreover, 80% is a pretty arbitrary value as it depends on the total disk capacity so degrading the cluster doesn't really make sense.

I think we should do the following:

  • Have "low" and "high" watermarks. Let 80% be a soft limit and 90% a hard limit (unconfigurable for now for simplicity).
  • Low watermark triggers a warning probe.
  • High watermark triggers a critical probe (like now).
  • Make sure there's a possibility to easily override both of these via a manual knob in emergency. For example via /etc/container-environment variable like other Planet's variables.
  • Upgrade command should give user a message if there are any active warnings and alert the user to their presence, but allow to override with --force flag.

The first 4 itemts should be backported back to 5.2. The last one - back to 5.5.

@r0mant r0mant added port/5.5 Requires port to version/5.5.x port/6.1 Requires port to version/6.1.x priority/1 Medium priority labels Jun 5, 2020
@r0mant r0mant changed the title Raise satellite disk check high watermark Downgrade disk high watermark check to warning Jun 5, 2020
@r0mant r0mant added the port/7.0 Requires port to version/7.0.x label Jun 5, 2020
@r0mant r0mant changed the title Downgrade disk high watermark check to warning Split disk watermark check into low and high Jun 5, 2020
@r0mant
Copy link
Contributor Author

r0mant commented Jun 16, 2020

Released in 5.5.48, 7.0.8. Will be released in next 6.1 as well.

@r0mant r0mant closed this as completed Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
port/5.5 Requires port to version/5.5.x port/6.1 Requires port to version/6.1.x port/7.0 Requires port to version/7.0.x priority/1 Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants